Issue 5575048: passing flags to firefox driver.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5575048: passing flags to firefox driver.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by francois.reynaud

Modified:
12 years, 3 months ago

Reviewers:
Eran

Base URL:
http://selenium.googlecode.com/svn/trunk

Visibility:
Public.

Description

passing flags to FF via the capabilities object, similar to what chrome driver does with chrome.switches.

Patch Set 1 #

Total comments: 4

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -4 lines)			Patch
		java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java	View		6 chunks	+41 lines, -2 lines	2 comments	Download
		java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java	View		2 chunks	+7 lines, -2 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Eran

12 years, 3 months ago (2012-02-01 15:52:31 UTC) #2

http://codereview.appspot.com/5575048/diff/1/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java (right):

http://codereview.appspot.com/5575048/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java:95: 
Is there a reason to have the variable params, rather than just create  the new
CommandLine with allParams.toArray ?

http://codereview.appspot.com/5575048/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java:300: 
The return is outside the else statement; you could drop the else statement
entirely.

http://codereview.appspot.com/5575048/diff/1/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java (right):

http://codereview.appspot.com/5575048/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java:65: public static
final String PROFILE = "firefox_profile";
Better name it firefox.arguments, or firefox_arguments. Also, update the wiki:
http://code.google.com/p/selenium/wiki/DesiredCapabilities

http://codereview.appspot.com/5575048/diff/1/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/firefox/FirefoxDriver.java:129:
FirefoxBinary binary = null;
As we discussed, this if statement is unnecessary - the default c'tor for
FirefoxBinary delegates to FirefoxBinary(null).

Expand All Messages | Collapse All Messages