Issue 55750043: Fix for b/12589674 Running adaptor from windows machine expects to have sharepoint username and pas…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55750043: Fix for b/12589674 Running adaptor from windows machine expects to have sharepoint username and pas… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by Tanmay Vartak

Modified:
10 years, 3 months ago

Reviewers:
ejona

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Fix for b/12589674 Running adaptor from windows machine expects to have sharepoint username and pas…

Patch Set 2 : Replaced isNullOrEmpty with empty check #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java	View	1	3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ejona

This looks great. Just the small change. https://codereview.appspot.com/55750043/diff/1/src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java File src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java (right): https://codereview.appspot.com/55750043/diff/1/src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java#newcode88 src/com/google/enterprise/adaptor/sharepoint/FormsAuthenticationHandler.java:88: if (Strings.isNullOrEmpty(userName) ...

10 years, 3 months ago (2014-01-22 18:50:41 UTC) #2

Please close

Expand All Messages | Collapse All Messages