Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 557410043: Special-case syntax error of duration before octave marks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by dak
Modified:
3 months ago
Reviewers:
lemzwerg, carl.d.sorensen, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Special-case syntax error of duration before octave marks A somewhat common note-entry error is to write something like c4'' that is (judging from my own experience) not even unusual for experienced users to fall victim to occasionally. So make a special parser rule that deals "correctly" with that entry and delivers a more helpful error message than the parser would muster on its own.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Han-Wen's suggestion of folding the parser rule was a lot more effort since duration is optional in… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M lily/parser.yy View 1 4 chunks +42 lines, -10 lines 0 comments Download

Messages

Total messages: 9
lemzwerg
Good idea! From inspection only, LGTM.
3 months, 1 week ago (2020-02-11 21:46:52 UTC) #1
Carl
On 2020/02/11 21:46:52, lemzwerg wrote: > Good idea! From inspection only, LGTM. Sounds like a ...
3 months, 1 week ago (2020-02-11 22:37:39 UTC) #2
dak
On 2020/02/11 22:37:39, Carl wrote: > On 2020/02/11 21:46:52, lemzwerg wrote: > > Good idea! ...
3 months, 1 week ago (2020-02-11 22:42:39 UTC) #3
hanwenn
https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy#newcode3676 lily/parser.yy:3676: | pitch exclamations questions octave_check duration stray_quotes optional_rest post_events ...
3 months, 1 week ago (2020-02-12 06:45:08 UTC) #4
dak
https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/557410043/diff/545570043/lily/parser.yy#newcode3676 lily/parser.yy:3676: | pitch exclamations questions octave_check duration stray_quotes optional_rest post_events ...
3 months, 1 week ago (2020-02-12 10:38:16 UTC) #5
dak
Han-Wen's suggestion of folding the parser rule was a lot more effort since duration is ...
3 months, 1 week ago (2020-02-12 12:15:50 UTC) #6
hanwenn
looks OK. Is there a way to exercise this? Maybe with #{ c4'' #} or ...
3 months, 1 week ago (2020-02-13 13:37:52 UTC) #7
dak
On 2020/02/13 13:37:52, hanwenn wrote: > looks OK. > > Is there a way to ...
3 months, 1 week ago (2020-02-13 14:17:47 UTC) #8
hanwenn
3 months ago (2020-02-19 09:42:41 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b