Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(760)

Issue 557380044: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by hanwenn
Modified:
7 months, 1 week ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

input/regression/multi-measure-rest-reminder: a demo of user-defined grobs Uses recently added features to build a text reminder at the top of the page of the last multi measure rests count.

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
A input/regression/multi-measure-rest-reminder.ly View 1 1 chunk +94 lines, -0 lines 2 comments Download

Messages

Total messages: 11
hahnjo
Thanks for providing a test. Not able to run it right now, maybe tomorrow. https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly ...
7 months, 2 weeks ago (2020-02-10 21:28:53 UTC) #1
Jean-Charles
Are you a French forensics? (DNA is adn for us) https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right): https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly#newcode6 ...
7 months, 2 weeks ago (2020-02-11 10:56:42 UTC) #2
hahnjo
On 2020/02/10 21:28:53, hahnjo wrote: > Thanks for providing a test. Not able to run ...
7 months, 2 weeks ago (2020-02-11 12:09:12 UTC) #3
hanwenn
nits
7 months, 2 weeks ago (2020-02-11 21:03:24 UTC) #4
hanwenn
fixed nits.
7 months, 2 weeks ago (2020-02-11 21:03:38 UTC) #5
thomasmorley651
Sorry being that late to the party. Though, I'm confused. Iiuc a new grob called ...
7 months, 1 week ago (2020-02-16 12:06:33 UTC) #6
thomasmorley651
https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right): https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly#newcode26 input/regression/multi-measure-rest-reminder.ly:26: #(set-object-property! 'MultiMeasureRestReminder 'translation-type? ly:grob-properties?) To make further overrides possible, ...
7 months, 1 week ago (2020-02-16 13:45:30 UTC) #7
hanwenn
https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly File input/regression/multi-measure-rest-reminder.ly (right): https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly#newcode26 input/regression/multi-measure-rest-reminder.ly:26: #(set-object-property! 'MultiMeasureRestReminder 'translation-type? ly:grob-properties?) On 2020/02/16 13:45:30, thomasmorley651 wrote: ...
7 months, 1 week ago (2020-02-17 10:01:29 UTC) #8
dak
On 2020/02/17 10:01:29, hanwenn wrote: > https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly > File input/regression/multi-measure-rest-reminder.ly (right): > > https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly#newcode26 > ...
7 months, 1 week ago (2020-02-17 10:48:59 UTC) #9
thomasmorley651
On 2020/02/17 10:01:29, hanwenn wrote: > https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly > File input/regression/multi-measure-rest-reminder.ly (right): > > https://codereview.appspot.com/557380044/diff/569320045/input/regression/multi-measure-rest-reminder.ly#newcode26 > ...
7 months, 1 week ago (2020-02-17 21:12:46 UTC) #10
hanwenn
7 months, 1 week ago (2020-02-19 09:38:33 UTC) #11
commit e3be140a8141f0236cd489cd97e7fcf735653a0b
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Mon Feb 10 22:10:35 2020 +0100

    input/regression/multi-measure-rest-reminder: a demo of user-defined grobs
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b