Issue 5571045: Adjust paths to account for vertical text metrics.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5571045: Adjust paths to account for vertical text metrics.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by caryclark1

Modified:
12 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Adjust paths to account for vertical text metrics. See http://code.google.com/p/chromium/issues/detail?id=111032 BUG=460 TEST=<try repro step in Chromium bug>

Patch Set 2 : add SkIntToScalar calls #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/ports/SkFontHost_mac_coretext.cpp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

lgtm w/ SkIntToScalar additions https://codereview.appspot.com/5571045/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/5571045/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode1291 src/ports/SkFontHost_mac_coretext.cpp:1291: getVerticalOffset(cgGlyph, &offset); ->offset(SkIntToScalar(offset.fX), ...)

12 years, 3 months ago (2012-01-25 16:31:37 UTC) #1

caryclark1

12 years, 3 months ago (2012-01-25 16:48:14 UTC) #2

Thanks

On Wed, Jan 25, 2012 at 11:31 AM,  <reed@google.com> wrote:
> lgtm w/ SkIntToScalar additions
>
>
>
https://codereview.appspot.com/5571045/diff/1/src/ports/SkFontHost_mac_corete...
> File src/ports/SkFontHost_mac_coretext.cpp (right):
>
>
https://codereview.appspot.com/5571045/diff/1/src/ports/SkFontHost_mac_corete...
> src/ports/SkFontHost_mac_coretext.cpp:1291: getVerticalOffset(cgGlyph,
> &offset);
> ->offset(SkIntToScalar(offset.fX), ...)
>
> https://codereview.appspot.com/5571045/

Expand All Messages | Collapse All Messages