Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6919)

Issue 5565043: code review 5565043: time: add default location parameter to time.Parse

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by ziutek
Modified:
12 years, 3 months ago
Reviewers:
r2, golang-dev
Visibility:
Public.

Description

time: add default location parameter to time.Parse If time.Parse isn't intended to parse only well defined timestamps from network protocols or file formats, it should accept additional parameter: location for which a time need to be generated. See: http://groups.google.com/group/golang-nuts/browse_thread/thread/99cd159a135a8e7d

Patch Set 1 #

Patch Set 2 : diff -r b372a927701e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b372a927701e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -56 lines) Patch
M misc/dashboard/builder/http.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/archive/zip/reader_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/asn1/asn1.go View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/net/http/cookie.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/http/fs.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/mail/message.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/time/format.go View 1 5 chunks +7 lines, -7 lines 0 comments Download
M src/pkg/time/time.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/time/time_test.go View 1 10 chunks +53 lines, -39 lines 0 comments Download

Messages

Total messages: 2
ziutek
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 3 months ago (2012-01-21 23:57:45 UTC) #1
r2
12 years, 3 months ago (2012-01-21 23:59:07 UTC) #2
No. We are not changing the signature of time.Parse at this time.

-rob

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b