Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2459)

Issue 5564059: code review 5564059: go.crypto: initial code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by rsc
Modified:
7 years, 10 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

go.crypto: initial code Manual edits to README. Moved from main Go repository, deleted Makefiles, ran gofix -r go1rename. Tested with: go test code.google.com/p/go.crypto/...

Patch Set 1 #

Patch Set 2 : diff -r b50a7fb49394 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r b50a7fb49394 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r b50a7fb49394 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15447 lines, -15 lines) Patch
M README View 1 1 chunk +2 lines, -15 lines 0 comments Download
A bcrypt/base64.go View 1 1 chunk +35 lines, -0 lines 0 comments Download
A bcrypt/bcrypt.go View 1 2 1 chunk +282 lines, -0 lines 0 comments Download
A bcrypt/bcrypt_test.go View 1 1 chunk +194 lines, -0 lines 0 comments Download
A blowfish/block.go View 1 1 chunk +192 lines, -0 lines 0 comments Download
A blowfish/blowfish_test.go View 1 1 chunk +210 lines, -0 lines 0 comments Download
A blowfish/cipher.go View 1 1 chunk +100 lines, -0 lines 0 comments Download
A blowfish/const.go View 1 1 chunk +199 lines, -0 lines 0 comments Download
A cast5/cast5.go View 1 1 chunk +534 lines, -0 lines 0 comments Download
A cast5/cast5_test.go View 1 1 chunk +104 lines, -0 lines 0 comments Download
A md4/md4.go View 1 1 chunk +118 lines, -0 lines 0 comments Download
A md4/md4_test.go View 1 1 chunk +71 lines, -0 lines 0 comments Download
A md4/md4block.go View 1 1 chunk +89 lines, -0 lines 0 comments Download
A ocsp/ocsp.go View 1 1 chunk +191 lines, -0 lines 0 comments Download
A ocsp/ocsp_test.go View 1 1 chunk +107 lines, -0 lines 0 comments Download
A openpgp/armor/armor.go View 1 2 1 chunk +219 lines, -0 lines 0 comments Download
A openpgp/armor/armor_test.go View 1 1 chunk +95 lines, -0 lines 0 comments Download
A openpgp/armor/encode.go View 1 1 chunk +160 lines, -0 lines 0 comments Download
A openpgp/canonical_text.go View 1 1 chunk +59 lines, -0 lines 0 comments Download
A openpgp/canonical_text_test.go View 1 1 chunk +52 lines, -0 lines 0 comments Download
A openpgp/elgamal/elgamal.go View 1 1 chunk +122 lines, -0 lines 0 comments Download
A openpgp/elgamal/elgamal_test.go View 1 1 chunk +49 lines, -0 lines 0 comments Download
A openpgp/errors/errors.go View 1 1 chunk +64 lines, -0 lines 0 comments Download
A openpgp/keys.go View 1 2 1 chunk +546 lines, -0 lines 0 comments Download
A openpgp/packet/compressed.go View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A openpgp/packet/compressed_test.go View 1 1 chunk +41 lines, -0 lines 0 comments Download
A openpgp/packet/encrypted_key.go View 1 2 1 chunk +167 lines, -0 lines 0 comments Download
A openpgp/packet/encrypted_key_test.go View 1 1 chunk +126 lines, -0 lines 0 comments Download
A openpgp/packet/literal.go View 1 1 chunk +89 lines, -0 lines 0 comments Download
A openpgp/packet/one_pass_signature.go View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A openpgp/packet/packet.go View 1 2 1 chunk +482 lines, -0 lines 0 comments Download
A openpgp/packet/packet_test.go View 1 2 1 chunk +255 lines, -0 lines 0 comments Download
A openpgp/packet/private_key.go View 1 2 1 chunk +310 lines, -0 lines 0 comments Download
A openpgp/packet/private_key_test.go View 1 1 chunk +58 lines, -0 lines 0 comments Download
A openpgp/packet/public_key.go View 1 2 1 chunk +414 lines, -0 lines 0 comments Download
A openpgp/packet/public_key_test.go View 1 1 chunk +99 lines, -0 lines 0 comments Download
A openpgp/packet/reader.go View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A openpgp/packet/signature.go View 1 2 1 chunk +611 lines, -0 lines 0 comments Download
A openpgp/packet/signature_test.go View 1 1 chunk +42 lines, -0 lines 0 comments Download
A openpgp/packet/symmetric_key_encrypted.go View 1 2 1 chunk +161 lines, -0 lines 0 comments Download
A openpgp/packet/symmetric_key_encrypted_test.go View 1 1 chunk +101 lines, -0 lines 0 comments Download
A openpgp/packet/symmetrically_encrypted.go View 1 2 1 chunk +289 lines, -0 lines 0 comments Download
A openpgp/packet/symmetrically_encrypted_test.go View 1 2 1 chunk +124 lines, -0 lines 0 comments Download
A openpgp/packet/userid.go View 1 1 chunk +160 lines, -0 lines 0 comments Download
A openpgp/packet/userid_test.go View 1 1 chunk +87 lines, -0 lines 0 comments Download
A openpgp/read.go View 1 2 1 chunk +414 lines, -0 lines 0 comments Download
A openpgp/read_test.go View 1 2 1 chunk +372 lines, -0 lines 0 comments Download
A openpgp/s2k/s2k.go View 1 2 1 chunk +183 lines, -0 lines 0 comments Download
A openpgp/s2k/s2k_test.go View 1 1 chunk +118 lines, -0 lines 0 comments Download
A openpgp/write.go View 1 2 1 chunk +315 lines, -0 lines 0 comments Download
A openpgp/write_test.go View 1 1 chunk +232 lines, -0 lines 0 comments Download
A ripemd160/ripemd160.go View 1 1 chunk +120 lines, -0 lines 0 comments Download
A ripemd160/ripemd160_test.go View 1 1 chunk +64 lines, -0 lines 0 comments Download
A ripemd160/ripemd160block.go View 1 1 chunk +161 lines, -0 lines 0 comments Download
A ssh/channel.go View 1 1 chunk +318 lines, -0 lines 0 comments Download
A ssh/cipher.go View 1 1 chunk +88 lines, -0 lines 0 comments Download
A ssh/cipher_test.go View 1 1 chunk +62 lines, -0 lines 0 comments Download
A ssh/client.go View 1 1 chunk +505 lines, -0 lines 0 comments Download
A ssh/client_auth.go View 1 1 chunk +316 lines, -0 lines 0 comments Download
A ssh/client_auth_test.go View 1 1 chunk +257 lines, -0 lines 0 comments Download
A ssh/client_func_test.go View 1 1 chunk +61 lines, -0 lines 0 comments Download
A ssh/common.go View 1 1 chunk +239 lines, -0 lines 0 comments Download
A ssh/common_test.go View 1 1 chunk +26 lines, -0 lines 0 comments Download
A ssh/doc.go View 1 1 chunk +127 lines, -0 lines 0 comments Download
A ssh/messages.go View 1 1 chunk +640 lines, -0 lines 0 comments Download
A ssh/messages_test.go View 1 1 chunk +125 lines, -0 lines 0 comments Download
A ssh/server.go View 1 1 chunk +676 lines, -0 lines 0 comments Download
A ssh/server_terminal.go View 1 1 chunk +81 lines, -0 lines 0 comments Download
A ssh/session.go View 1 1 chunk +494 lines, -0 lines 0 comments Download
A ssh/session_test.go View 1 1 chunk +374 lines, -0 lines 0 comments Download
A ssh/tcpip.go View 1 1 chunk +132 lines, -0 lines 0 comments Download
A ssh/tcpip_func_test.go View 1 1 chunk +59 lines, -0 lines 0 comments Download
A ssh/transport.go View 1 1 chunk +369 lines, -0 lines 0 comments Download
A ssh/transport_test.go View 1 1 chunk +51 lines, -0 lines 0 comments Download
A twofish/twofish.go View 1 1 chunk +355 lines, -0 lines 0 comments Download
A twofish/twofish_test.go View 1 1 chunk +129 lines, -0 lines 0 comments Download
A xtea/block.go View 1 1 chunk +66 lines, -0 lines 0 comments Download
A xtea/cipher.go View 1 1 chunk +89 lines, -0 lines 0 comments Download
A xtea/xtea_test.go View 1 1 chunk +246 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
7 years, 10 months ago (2012-01-25 20:19:17 UTC) #1
bradfitz
LGTM On Wed, Jan 25, 2012 at 12:19 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
7 years, 10 months ago (2012-01-25 20:28:22 UTC) #2
rsc
7 years, 10 months ago (2012-01-25 20:31:15 UTC) #3
*** Submitted as f4b96aaf712d ***

go.crypto: initial code

Manual edits to README.
Moved from main Go repository, deleted Makefiles, ran gofix -r go1rename.

Tested with: go test code.google.com/p/go.crypto/...

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5564059
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b