Code review - Issue 5564059: code review 5564059: go.crypto: initial codehttps://codereview.appspot.com/2012-01-25T20:31:15+00:00rietveld
Message from unknown
2012-01-25T20:15:53+00:00rscurn:md5:290f567ff83473096186da04ee5f6b9f
Message from unknown
2012-01-25T20:15:57+00:00rscurn:md5:442d2e8450f21e6b4441b1d978972ca4
Message from unknown
2012-01-25T20:18:58+00:00rscurn:md5:7d6a33ee2848f9d9b66b734911c2f353
Message from rsc@golang.org
2012-01-25T20:19:17+00:00rscurn:md5:e8bf9d041c976193cd8aa1a806baf511
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://code.google.com/p/go.crypto
Message from bradfitz@golang.org
2012-01-25T20:28:22+00:00bradfitzurn:md5:4f9189b6999c71b9979b656ca314e681
LGTM
On Wed, Jan 25, 2012 at 12:19 PM, <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go.**crypto<https://code.google.com/p/go.crypto>
>
>
> Description:
> go.crypto: initial code
>
> Manual edits to README.
> Moved from main Go repository, deleted Makefiles, ran gofix -r
> go1rename.
>
> Tested with: go test code.google.com/p/go.crypto/..**.
>
> Please review this at http://codereview.appspot.com/**5564059/<http://codereview.appspot.com/5564059/>
>
> Affected files:
> M README
> A bcrypt/base64.go
> A bcrypt/bcrypt.go
> A bcrypt/bcrypt_test.go
> A blowfish/block.go
> A blowfish/blowfish_test.go
> A blowfish/cipher.go
> A blowfish/const.go
> A cast5/cast5.go
> A cast5/cast5_test.go
> A md4/md4.go
> A md4/md4_test.go
> A md4/md4block.go
> A ocsp/ocsp.go
> A ocsp/ocsp_test.go
> A openpgp/armor/armor.go
> A openpgp/armor/armor_test.go
> A openpgp/armor/encode.go
> A openpgp/canonical_text.go
> A openpgp/canonical_text_test.go
> A openpgp/elgamal/elgamal.go
> A openpgp/elgamal/elgamal_test.**go
> A openpgp/errors/errors.go
> A openpgp/keys.go
> A openpgp/packet/compressed.go
> A openpgp/packet/compressed_**test.go
> A openpgp/packet/encrypted_key.**go
> A openpgp/packet/encrypted_key_**test.go
> A openpgp/packet/literal.go
> A openpgp/packet/one_pass_**signature.go
> A openpgp/packet/packet.go
> A openpgp/packet/packet_test.go
> A openpgp/packet/private_key.go
> A openpgp/packet/private_key_**test.go
> A openpgp/packet/public_key.go
> A openpgp/packet/public_key_**test.go
> A openpgp/packet/reader.go
> A openpgp/packet/signature.go
> A openpgp/packet/signature_test.**go
> A openpgp/packet/symmetric_key_**encrypted.go
> A openpgp/packet/symmetric_key_**encrypted_test.go
> A openpgp/packet/symmetrically_**encrypted.go
> A openpgp/packet/symmetrically_**encrypted_test.go
> A openpgp/packet/userid.go
> A openpgp/packet/userid_test.go
> A openpgp/read.go
> A openpgp/read_test.go
> A openpgp/s2k/s2k.go
> A openpgp/s2k/s2k_test.go
> A openpgp/write.go
> A openpgp/write_test.go
> A ripemd160/ripemd160.go
> A ripemd160/ripemd160_test.go
> A ripemd160/ripemd160block.go
> A ssh/channel.go
> A ssh/cipher.go
> A ssh/cipher_test.go
> A ssh/client.go
> A ssh/client_auth.go
> A ssh/client_auth_test.go
> A ssh/client_func_test.go
> A ssh/common.go
> A ssh/common_test.go
> A ssh/doc.go
> A ssh/messages.go
> A ssh/messages_test.go
> A ssh/server.go
> A ssh/server_terminal.go
> A ssh/session.go
> A ssh/session_test.go
> A ssh/tcpip.go
> A ssh/tcpip_func_test.go
> A ssh/transport.go
> A ssh/transport_test.go
> A twofish/twofish.go
> A twofish/twofish_test.go
> A xtea/block.go
> A xtea/cipher.go
> A xtea/xtea_test.go
>
>
>
Message from unknown
2012-01-25T20:30:51+00:00rscurn:md5:57ed0f859dc2b324277e396a60f4e681
Message from rsc@golang.org
2012-01-25T20:31:15+00:00rscurn:md5:b85ac130f15394e9b92021f5af0e2d83
*** Submitted as f4b96aaf712d ***
go.crypto: initial code
Manual edits to README.
Moved from main Go repository, deleted Makefiles, ran gofix -r go1rename.
Tested with: go test code.google.com/p/go.crypto/...
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5564059