Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1438)

Issue 555360043: Add a cooperative FS lock to lilypond-book. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 2 weeks ago by hanwenn
Modified:
3 months, 3 weeks ago
Reviewers:
dak, thomasmorley651, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add a cooperative FS lock to lilypond-book. This simplifies the build infrastructure, because it obviates Makefile hacks to force a single lilypond-book processes during the build

Patch Set 1 #

Total comments: 6

Patch Set 2 : fcntl #

Patch Set 3 : timing test #

Patch Set 4 : spaces #

Patch Set 5 : eager checksums #

Patch Set 6 : harden #

Patch Set 7 : lockfilename #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -16 lines) Patch
M input/regression/lilypond-book/GNUmakefile View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M make/ly-rules.make View 1 2 3 4 5 6 7 1 chunk +0 lines, -9 lines 0 comments Download
M scripts/lilypond-book.py View 1 2 3 4 5 6 7 3 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 36
hahnjo
The current change leaves a few questions unanswered: What should lilypond-book do if there happens ...
4 months, 2 weeks ago (2020-02-23 15:18:27 UTC) #1
hanwenn
I think this is worth it because it simplifies the build system, and puts the ...
4 months, 2 weeks ago (2020-02-23 15:54:54 UTC) #2
hahnjo
On 2020/02/23 15:54:54, hanwenn wrote: > I think this is worth it because it simplifies ...
4 months, 2 weeks ago (2020-02-23 15:59:14 UTC) #3
hanwenn
fcntl
4 months, 2 weeks ago (2020-02-23 16:04:01 UTC) #4
dak
On 2020/02/23 15:54:54, hanwenn wrote: > I think this is worth it because it simplifies ...
4 months, 2 weeks ago (2020-02-23 16:05:08 UTC) #5
hanwenn
timing test
4 months, 2 weeks ago (2020-02-23 16:23:30 UTC) #6
hanwenn
On 2020/02/23 16:05:08, dak wrote: > On 2020/02/23 15:54:54, hanwenn wrote: > > I think ...
4 months, 2 weeks ago (2020-02-23 16:23:34 UTC) #7
dak
On 2020/02/23 16:23:34, hanwenn wrote: > On 2020/02/23 16:05:08, dak wrote: > > On 2020/02/23 ...
4 months, 2 weeks ago (2020-02-23 16:29:20 UTC) #8
hanwenn
spaces
4 months, 2 weeks ago (2020-02-23 16:31:12 UTC) #9
hanwenn
On 2020/02/23 16:29:20, dak wrote: > On 2020/02/23 16:23:34, hanwenn wrote: > > On 2020/02/23 ...
4 months, 2 weeks ago (2020-02-23 16:36:44 UTC) #10
hanwenn
eager checksums
4 months, 2 weeks ago (2020-02-23 16:42:45 UTC) #11
dak
On 2020/02/23 15:59:14, hahnjo wrote: > On 2020/02/23 15:54:54, hanwenn wrote: > > I think ...
4 months, 2 weeks ago (2020-02-23 16:45:11 UTC) #12
hanwenn
harden
4 months, 2 weeks ago (2020-02-23 18:51:33 UTC) #13
hanwenn
Jonas, did you want to have another look?
4 months, 2 weeks ago (2020-02-25 08:09:21 UTC) #14
hahnjo
On 2020/02/25 08:09:21, hanwenn wrote: > Jonas, did you want to have another look? Yes, ...
4 months, 2 weeks ago (2020-02-25 09:06:40 UTC) #15
hahnjo
So I can see a consistent improvement by ~40s for 'make -j4 CPU_COUNT=4 test', going ...
4 months, 2 weeks ago (2020-02-25 22:09:06 UTC) #16
hanwenn
On Tue, Feb 25, 2020 at 11:09 PM <jonas.hahnfeld@gmail.com> wrote: > Another solution might be ...
4 months, 2 weeks ago (2020-02-26 07:59:36 UTC) #17
hahnjo
On 2020/02/26 07:59:36, hanwenn wrote: > On Tue, Feb 25, 2020 at 11:09 PM <mailto:jonas.hahnfeld@gmail.com> ...
4 months, 2 weeks ago (2020-02-26 08:19:39 UTC) #18
hahnjo
On 2020/02/26 08:19:39, hahnjo wrote: > On 2020/02/26 07:59:36, hanwenn wrote: > > On Tue, ...
4 months, 2 weeks ago (2020-02-26 08:28:33 UTC) #19
hanwenn
On Wed, Feb 26, 2020 at 9:19 AM <jonas.hahnfeld@gmail.com> wrote: > > A lock (a ...
4 months, 2 weeks ago (2020-02-26 08:59:58 UTC) #20
hanwenn
lockfilename
4 months, 2 weeks ago (2020-02-26 09:48:04 UTC) #21
hanwenn
On Wed, Feb 26, 2020 at 9:59 AM Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > In this ...
4 months, 2 weeks ago (2020-02-26 09:52:35 UTC) #22
dak
On 2020/02/26 08:28:33, hahnjo wrote: > On 2020/02/26 08:19:39, hahnjo wrote: > > > On ...
4 months, 2 weeks ago (2020-02-26 11:59:14 UTC) #23
hanwenn
On 2020/02/26 11:59:14, dak wrote: > On 2020/02/26 08:28:33, hahnjo wrote: > > On 2020/02/26 ...
4 months, 1 week ago (2020-02-28 17:57:06 UTC) #24
dak
On 2020/02/28 17:57:06, hanwenn wrote: > On 2020/02/26 11:59:14, dak wrote: > > It doesn't ...
4 months, 1 week ago (2020-02-28 18:14:14 UTC) #25
hanwenn
rebase
4 months, 1 week ago (2020-03-01 16:48:23 UTC) #26
dak
On 2020/02/28 18:14:14, dak wrote: > On 2020/02/28 17:57:06, hanwenn wrote: > > On 2020/02/26 ...
4 months ago (2020-03-06 22:18:17 UTC) #27
hanwenn
On Fri, Mar 6, 2020 at 11:18 PM <dak@gnu.org> wrote: > > Sigh. I just ...
4 months ago (2020-03-07 10:56:18 UTC) #28
dak
Han-Wen Nienhuys <hanwenn@gmail.com> writes: > On Fri, Mar 6, 2020 at 11:18 PM <dak@gnu.org> wrote: ...
4 months ago (2020-03-07 12:39:31 UTC) #29
thomasmorley651
On 2020/03/07 12:39:31, dak wrote: > Han-Wen Nienhuys <mailto:hanwenn@gmail.com> writes: > > > On Fri, ...
4 months ago (2020-03-07 15:08:24 UTC) #30
dak
thomasmorley65@gmail.com writes: > On 2020/03/07 12:39:31, dak wrote: >> >> Harm has a system with ...
4 months ago (2020-03-07 15:30:33 UTC) #31
hanwenn
On Sat, Mar 7, 2020 at 4:30 PM David Kastrup <dak@gnu.org> wrote: > that starts ...
4 months ago (2020-03-07 15:59:12 UTC) #32
hanwenn
On Sat, Mar 7, 2020 at 1:39 PM David Kastrup <dak@gnu.org> wrote: > >> "It ...
4 months ago (2020-03-08 09:35:23 UTC) #33
hanwenn
On Sun, Mar 8, 2020 at 10:35 AM Han-Wen Nienhuys <hanwenn@gmail.com> wrote: > > To ...
4 months ago (2020-03-08 10:11:27 UTC) #34
thomasmorley651
On 2020/03/07 15:30:33, dak wrote: > mailto:thomasmorley65@gmail.com writes: > > > On 2020/03/07 12:39:31, dak ...
4 months ago (2020-03-08 14:59:30 UTC) #35
hanwenn
3 months, 3 weeks ago (2020-03-21 12:31:06 UTC) #36
commit 7ab9c8fa4faff7a513d0ecfbc7eecf7efd2b8ea8
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Sun Mar 1 17:47:53 2020 +0100

    Add a FS lock to lilypond-book
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b