Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(202)

Issue 555160043: document and test slur score debugging (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by hanwenn
Modified:
3 months, 2 weeks ago
Reviewers:
dak, lemzwerg, Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

document and test slur score debugging

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 2

Patch Set 3 : inspect-index #

Total comments: 1

Patch Set 4 : .ly file #

Total comments: 3

Patch Set 5 : address wl comments #

Patch Set 6 : .ly typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
A input/regression/slur-inspect-quants.ly View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download
M lily/include/slur-engraver.hh View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M lily/slur.cc View 1 2 3 4 2 chunks +6 lines, -3 lines 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12
hanwenn
tweaks
4 months, 1 week ago (2020-01-20 09:39:43 UTC) #1
dak
https://codereview.appspot.com/555160043/diff/569260043/lily/slur.cc File lily/slur.cc (left): https://codereview.appspot.com/555160043/diff/569260043/lily/slur.cc#oldcode576 lily/slur.cc:576: "inspect-index " Is the removal of the inspect-index property ...
4 months, 1 week ago (2020-01-20 11:33:00 UTC) #2
hanwenn
inspect-index
4 months, 1 week ago (2020-01-20 21:01:41 UTC) #3
hanwenn
On 2020/01/20 21:01:41, hanwenn wrote: > inspect-index PTAL
4 months, 1 week ago (2020-01-20 21:04:35 UTC) #4
lemzwerg
LGTM, thanks!
4 months, 1 week ago (2020-01-21 08:18:43 UTC) #5
Dan Eble
https://codereview.appspot.com/555160043/diff/577340043/input/regression/slur-inspect-quants.ly File input/regression/slur-inspect-quants.ly (right): https://codereview.appspot.com/555160043/diff/577340043/input/regression/slur-inspect-quants.ly#newcode3 input/regression/slur-inspect-quants.ly:3: texidoc = "This file demonstrates the slur scoring debug ...
4 months, 1 week ago (2020-01-21 14:44:04 UTC) #6
hanwenn
On 2020/01/21 14:44:04, Dan Eble wrote: > https://codereview.appspot.com/555160043/diff/577340043/input/regression/slur-inspect-quants.ly > File input/regression/slur-inspect-quants.ly (right): > > https://codereview.appspot.com/555160043/diff/577340043/input/regression/slur-inspect-quants.ly#newcode3 ...
4 months, 1 week ago (2020-01-22 09:04:10 UTC) #7
hanwenn
.ly file
4 months, 1 week ago (2020-01-22 09:04:26 UTC) #8
lemzwerg
Some minor nits... https://codereview.appspot.com/555160043/diff/549440043/lily/slur.cc File lily/slur.cc (right): https://codereview.appspot.com/555160043/diff/549440043/lily/slur.cc#newcode495 lily/slur.cc:495: "Slurs are formatted by a number ...
4 months, 1 week ago (2020-01-22 09:33:59 UTC) #9
hanwenn
address wl comments
4 months ago (2020-01-30 08:45:19 UTC) #10
hanwenn
.ly typo
3 months, 4 weeks ago (2020-01-31 08:51:27 UTC) #11
hanwenn
3 months, 2 weeks ago (2020-02-13 11:38:31 UTC) #12
commit 20f3c9e7f51c9e9891a8bbc6378e9ca8f0ba02a2
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Mon Jan 20 10:19:55 2020 +0100

    document and test slur score debugging
    
    https://sourceforge.net/p/testlilyissues/issues/5674
    http://codereview.appspot.com/555160043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b