document and test slur score debugging

lily/slur.cc

 /*
   This file is part of LilyPond, the GNU music typesetter.
 
-  Copyright (C) 1996--2019 Han-Wen Nienhuys <hanwen@xs4all.nl>
+  Copyright (C) 1996--2020 Han-Wen Nienhuys <hanwen@xs4all.nl>
   Jan Nieuwenhuizen <janneke@gnu.org>
 
   LilyPond is free software: you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
   the Free Software Foundation, either version 3 of the License, or
   (at your option) any later version.
 
   LilyPond is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 21 matching lines @@
 #include "staff-symbol-referencer.hh"
 #include "stem.hh"
 #include "text-interface.hh"
 #include "tie.hh"
 #include "warn.hh"
 #include "slur-scoring.hh"
 #include "separation-item.hh"
 #include "unpure-pure-container.hh"
 #include "international.hh"
 
+using std::string;
+using std::vector;
+
 MAKE_SCHEME_CALLBACK (Slur, calc_direction, 1)
 SCM
 Slur::calc_direction (SCM smob)
 {
   Grob *me = unsmob<Grob> (smob);
   extract_grob_set (me, "note-columns", encompasses);
 
   if (encompasses.empty ())
     {
       me->suicide ();
@@ skipping 301 matching lines @@
                     break;
                 }
               if (do_shift)
                 break;
             }
           if (do_shift)
             break;
         }
     }
 
-  Real avoidance_offset = do_shift ? curve.minmax (X_AXIS, max (xext[LEFT], curve.control_[0][X_AXIS] + EPS), min (xext[RIGHT], curve.control_[3][X_AXIS] - EPS), dir) - yext[-dir] : 0.0;
+  Real avoidance_offset = do_shift ? curve.minmax (X_AXIS, std::max (xext[LEFT], curve.control_[0][X_AXIS] + EPS), std::min (xext[RIGHT], curve.control_[3][X_AXIS] - EPS), dir) - yext[-dir] : 0.0;
 
   return scm_from_double (offset + avoidance_offset);
 }
 
 MAKE_SCHEME_CALLBACK (Slur, vertical_skylines, 1);
 SCM
 Slur::vertical_skylines (SCM smob)
 {
   Grob *me = unsmob<Grob> (smob);
   vector<Box> boxes;
@@ skipping 107 matching lines @@
 
   Grob *common = common_refpoint_of_array (cols, me, Y_AXIS);
   common = common_refpoint_of_array (non_sep_extras, common, Y_AXIS);
 
   return scm_from_bool (common != me->get_parent (Y_AXIS));
 }
 
 ADD_INTERFACE (Slur,
                "A slur."
                "\n"
-               "Slurs are formatted by a number of combination of left/right "
-               "end-point, and then picking the slur with the lowest demerit score. "
-               "The combinations are generated by going from the base attachments "
-               "(ie. note heads) in the direction in half space increments until we "
-               "have covered @code{region-size} staff spaces. "
-               "The following properties may be set in the @code{details}"
+               "Slurs are formatted by trying a number of combinations of left/right"
+               " end point, and then picking the slur with the lowest demerit score."
+               " The combinations are generated by going from the base attachments"
+               " (i.e., note heads) in the direction in half space increments until we"
+               " have covered @code{region-size} staff spaces."
+               " The following properties may be set in the @code{details}"
                " list.\n"
                "\n"
                "@table @code\n"
                "@item region-size\n"
                "Size of region (in staff spaces) for determining"
                " potential endpoints in the Y direction.\n"
                "@item head-encompass-penalty\n"
                "Demerit to apply when note heads collide with a slur.\n"
                "@item stem-encompass-penalty\n"
                "Demerit to apply when stems collide with a slur.\n"
@@ skipping 66 matching lines @@
                "eccentricity "
                "encompass-objects "
                "height-limit "
                "inspect-quants "
                "line-thickness "
                "note-columns "
                "positions "
                "ratio "
                "thickness "
               );
-