code review 55500044: runtime: refactor level-triggered IO support

runtime: refactor level-triggered IO support
Remove GOOS_solaris ifdef from netpoll code,
instead introduce runtime edge/level triggered IO flag.
Replace armread/armwrite with a single arm(mode) function,
that's how all other interfaces look like and these functions
will need to do roughly the same thing anyway.

[dvyukov, 2014-01-22 07:54:12]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[dave_cheney.net, 2014-02-05 22:49:15]

On 2014/01/22 07:54:12, dvyukov wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/

Thanks Dmitry. Could static bool edgetriggered be moved into an enum in
os_$GOOS.h instead?

[dvyukov, 2014-02-06 14:50:34]

On 2014/02/05 22:49:15, dfc wrote:
> On 2014/01/22 07:54:12, dvyukov wrote:
> > Hello mailto:golang-codereviews@googlegroups.com,
> > 
> > I'd like you to review this change to
> > https://dvyukov%40google.com@code.google.com/p/go/
> 
> Thanks Dmitry. Could static bool edgetriggered be moved into an enum in
> os_$GOOS.h instead?

I don't like conditional branching and I am lazy, so PTAL :)

[dave_cheney.net, 2014-02-06 19:47:18]

> On 7 Feb 2014, at 1:50, dvyukov@google.com wrote:
> 
>> On 2014/02/05 22:49:15, dfc wrote:
>> On 2014/01/22 07:54:12, dvyukov wrote:
>> > Hello mailto:golang-codereviews@googlegroups.com,
>> >
>> > I'd like you to review this change to
>> > https://dvyukov%40google.com@code.google.com/p/go/
> 
>> Thanks Dmitry. Could static bool edgetriggered be moved into an enum
> in
>> os_$GOOS.h instead?
> 
> I don't like conditional branching and I am lazy, so PTAL :)

Where is Solaris defined? Is it a flag passed to the compiler via -D ?


> 
> https://codereview.appspot.com/55500044/

[dvyukov, 2014-02-06 19:53:28]

It's enum in runtime.h

On Thu, Feb 6, 2014 at 11:47 PM, Dave Cheney <dave@cheney.net> wrote:
>
>
>
>
>> On 7 Feb 2014, at 1:50, dvyukov@google.com wrote:
>>
>>> On 2014/02/05 22:49:15, dfc wrote:
>>> On 2014/01/22 07:54:12, dvyukov wrote:
>>> > Hello mailto:golang-codereviews@googlegroups.com,
>>> >
>>> > I'd like you to review this change to
>>> > https://dvyukov%40google.com@code.google.com/p/go/
>>
>>> Thanks Dmitry. Could static bool edgetriggered be moved into an enum
>> in
>>> os_$GOOS.h instead?
>>
>> I don't like conditional branching and I am lazy, so PTAL :)
>
> Where is Solaris defined? Is it a flag passed to the compiler via -D ?
>
>
>>
>> https://codereview.appspot.com/55500044/

[rsc, 2014-02-12 18:00:27]

LGTM

[dvyukov, 2014-02-12 18:24:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=cc6826ec23c7 ***

runtime: refactor level-triggered IO support
Remove GOOS_solaris ifdef from netpoll code,
instead introduce runtime edge/level triggered IO flag.
Replace armread/armwrite with a single arm(mode) function,
that's how all other interfaces look like and these functions
will need to do roughly the same thing anyway.

LGTM=rsc
R=golang-codereviews, dave, rsc
CC=golang-codereviews
https://codereview.appspot.com/55500044