Issue 5545050: support unicode variation selectors in textToGlyphs and containsText

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5545050: support unicode variation selectors in textToGlyphs and containsText

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by reed1

Modified:
12 years, 3 months ago

Reviewers:
bashi1

CC:
bungeman, caryclark1, yuzo_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Patch Set 2 : add changes to freetype and win ports #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -54 lines)			Patch
M	include/core/SkScalerContext.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/core/SkGlyphCache.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkGlyphCache.cpp	View		1 chunk	+11 lines, -7 lines	0 comments	Download
M	src/core/SkPaint.cpp	View		2 chunks	+75 lines, -14 lines	0 comments	Download
M	src/core/SkScalerContext.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/ports/SkFontHost_mac_coretext.cpp	View		2 chunks	+15 lines, -14 lines	0 comments	Download
M	src/ports/SkFontHost_win.cpp	View	1	2 chunks	+17 lines, -10 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

do we still think we want variation support in skia. If so, I propose something ...

12 years, 3 months ago (2012-01-13 16:26:16 UTC) #1

bashi1

12 years, 3 months ago (2012-01-16 00:19:23 UTC) #2

LGTM.

Thank you so much for working on this!

On 2012/01/13 16:26:16, reed1 wrote:
> do we still think we want variation support in skia. If so, I propose
something
> like this CL, where it is *only* supported in textToGlyphs(), and not directly
> support it when drawing (except when drawing glyphs ids of course).

Expand All Messages | Collapse All Messages