Issue 55390043: code review 55390043: lib/codereview: add LGTM= line to commit messages

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55390043: code review 55390043: lib/codereview: add LGTM= line to commit messages (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rsc

Modified:
11 years, 1 month ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

lib/codereview: add LGTM= line to commit messages The R= is populated by Rietveld, so it's basically anyone who replied to the CL. The LGTM= is meant to record who actually signed off on the CL.

Patch Set 1 #

Patch Set 2 : diff -r eee3e7a93639 https://code.google.com/p/go/ #

Patch Set 3 : diff -r eee3e7a93639 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 75adcf310434 https://code.google.com/p/go/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
	M	lib/codereview/codereview.py	View	1 2 3	4 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 1 month ago (2014-01-22 01:00:45 UTC) #1

rsc

11 years, 1 month ago (2014-01-23 20:10:44 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f837894cf5a9 ***

lib/codereview: add LGTM= line to commit messages

The R= is populated by Rietveld, so it's basically
anyone who replied to the CL. The LGTM= is meant
to record who actually signed off on the CL.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/55390043

Expand All Messages | Collapse All Messages