Issue 5534063: add SkPath::cheapComputeDirection for stroke_and_fill

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5534063: add SkPath::cheapComputeDirection for stroke_and_fill

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by reed1

Modified:
12 years, 3 months ago

Reviewers:
caryclark1

CC:
bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -6 lines)			Patch
M	include/core/SkPath.h	View	1 chunk	+18 lines, -0 lines	1 comment	Download
M	src/core/SkPath.cpp	View	1 chunk	+131 lines, -0 lines	1 comment	Download
M	src/core/SkStroke.cpp	View	1 chunk	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

caryclark1

12 years, 3 months ago (2012-01-10 17:09:14 UTC) #2

lgtm

http://codereview.appspot.com/5534063/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

http://codereview.appspot.com/5534063/diff/1/include/core/SkPath.h#newcode462
include/core/SkPath.h:462: bool cheapComputDirection(Direction* dir) const;
compute missing 'e'

http://codereview.appspot.com/5534063/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

http://codereview.appspot.com/5534063/diff/1/src/core/SkPath.cpp#newcode1954
src/core/SkPath.cpp:1954: // cheap version of i = (i + 1) % n;
seems curious to optimize here but have the non-optimized expression a few lines
up. Maybe the thought is that you'll rarely get to the i >= n-2 case?

Would it make sense to compute

next = i + 1;
if (next == n) {
  next = 0;
} 
etc
before the cross_prod and
i = next afterwards?

Expand All Messages | Collapse All Messages