Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(193)

Issue 553400043: EXPERIMENTAL: put a reminder of the mm rest on the last page at the top. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by hanwenn
Modified:
1 year, 7 months ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

EXPERIMENTAL: put a reminder of the mm rest on the last page at the top. Introduces grob MultiMeasureRestReminder, controlled by createMultiMeasureRestReminders. TODO: * regtest * a nicer layout of the reminder (use a mmrest-like symbol?) * more structured positioning and extent routines for the grob. (the grob should be ignored for pure computations.) Set page breaking properties in the System grob * Record system rank within page in rank-on-page property * Record page number in page-number property lily/page-breaking: pass vector by reference lily: fix some type conversion warnings Document why System::rank_type is int16 Documentation: fix typo in German spacing.itely file Documentation: fix typos in tool naming

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -18 lines) Patch
M Documentation/contributor/administration.itexi View 1 chunk +2 lines, -2 lines 0 comments Download
M Documentation/contributor/introduction.itexi View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/notation/spacing.itely View 1 chunk +1 line, -1 line 0 comments Download
M lily/break-substitution.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M lily/include/page-breaking.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/system.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/multi-measure-rest-engraver.cc View 4 chunks +10 lines, -2 lines 0 comments Download
M lily/page-breaking.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M lily/page-spacing-result.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/pointer-group-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/quote-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/stem.cc View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-context-properties.scm View 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 2 chunks +2 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Dan Eble
There's some stuff here that I already spent time reviewing, and having to sift through ...
1 year, 8 months ago (2020-01-24 18:57:56 UTC) #1
hanwenn
I'm not asking for anyone to review. It's context to the other change about multi-measure-rests. ...
1 year, 8 months ago (2020-01-24 19:29:56 UTC) #2
Dan Eble
On 2020/01/24 19:29:56, hanwenn wrote: > I'm not asking for anyone to review. It's context ...
1 year, 8 months ago (2020-01-25 14:57:17 UTC) #3
hanwenn
On Sat, Jan 25, 2020 at 3:57 PM <nine.fierce.ballads@gmail.com> wrote: > > I'm not asking ...
1 year, 8 months ago (2020-01-25 18:20:39 UTC) #4
hanwenn
1 year, 7 months ago (2020-02-19 09:41:32 UTC) #5
abandoning; implemented as user defined reminder instead
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b