Issue 5532098: charm metadata support for subordinates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5532098: charm metadata support for subordinates

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by bcsaller

Modified:
12 years, 2 months ago

Reviewers:
mp+84562, hazmat, niemeyer

Visibility:
Public.

Description

Charm directory, bundle and metadata support for subordinate charms and scoped relations https://code.launchpad.net/~bcsaller/juju/subordinate-charms/+merge/84562 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : charm metadata support for subordinates #

Total comments: 2

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+528 lines, -22 lines)			Patch
M	.bzrignore	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	docs/source/charm.rst	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	docs/source/charm-upgrades.rst	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
A	docs/source/drafts/implicit-relations.rst	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download
A	docs/source/drafts/subordinate-internals.rst	View	1	1 chunk	+168 lines, -0 lines	0 comments	Download
A	docs/source/drafts/subordinate-services.rst	View	1	1 chunk	+170 lines, -0 lines	0 comments	Download
M	juju/charm/metadata.py	View	1	6 chunks	+44 lines, -4 lines	2 comments	Download
A	juju/charm/tests/repository/series/logging/.ignored	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	juju/charm/tests/repository/series/logging/hooks/install	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	juju/charm/tests/repository/series/logging/metadata.yaml	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
A	juju/charm/tests/repository/series/logging/revision	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	juju/charm/tests/test_metadata.py	View	1	8 chunks	+50 lines, -14 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

On 2012/01/19 08:59:45, bcsaller wrote: > Please take a look. Please hold off on merging ...

12 years, 3 months ago (2012-01-19 11:39:54 UTC) #2

hazmat

lgtm +1, one minor. woot! first branch of subordinates. https://codereview.appspot.com/5532098/diff/4001/juju/charm/metadata.py File juju/charm/metadata.py (right): https://codereview.appspot.com/5532098/diff/4001/juju/charm/metadata.py#newcode228 juju/charm/metadata.py:228: ...

12 years, 2 months ago (2012-02-27 19:21:20 UTC) #4

bcsaller

12 years, 2 months ago (2012-02-28 00:22:58 UTC) #5

https://codereview.appspot.com/5532098/diff/4001/juju/charm/metadata.py
File juju/charm/metadata.py (right):

https://codereview.appspot.com/5532098/diff/4001/juju/charm/metadata.py#newco...
juju/charm/metadata.py:228: path)
On 2012/02/27 19:21:20, hazmat wrote:
> Feels like this should be an error that's raised.

It isn't currently because the other checks in the method only log. However
you're correct that this indicates a usage error and should be corrected so I'm
changing it to a MetadataError(...)

Expand All Messages | Collapse All Messages