Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6805)

Issue 553170043: Allow use of `libguile18.h` instead of `libguile.h`.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by lemzwerg
Modified:
2 weeks, 5 days ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow use of `libguile18.h` instead of `libguile.h`. This is for compilation on MacPorts, and I guess that more distributions will follow so that guile 1.8 and 2.x can be installed in parallel.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix thinko. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M aclocal.m4 View 1 chunk +1 line, -1 line 0 comments Download
M config.hh.in View 1 chunk +3 lines, -0 lines 0 comments Download
M configure.ac View 1 2 chunks +15 lines, -3 lines 0 comments Download
M lily/include/lily-guile.hh View 1 1 chunk +7 lines, -1 line 0 comments Download
M lily/include/ly-module.hh View 1 chunk +0 lines, -1 line 0 comments Download
M lily/include/mingw-compatibility.hh View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
hahnjo
https://codereview.appspot.com/553170043/diff/554980043/lily/include/lily-guile.hh File lily/include/lily-guile.hh (right): https://codereview.appspot.com/553170043/diff/554980043/lily/include/lily-guile.hh#newcode29 lily/include/lily-guile.hh:29: #ifdef HAVE_LIBGUILE18_H I think this should be `#if HAVE_LIBGUILE18_H` ...
2 weeks, 6 days ago (2019-11-17 17:13:37 UTC) #1
lemzwerg
> I think this should be `#if HAVE_LIBGUILE18_H` because it's > always defined AFAICS. This ...
2 weeks, 6 days ago (2019-11-17 17:17:23 UTC) #2
lemzwerg
Fix thinko.
2 weeks, 6 days ago (2019-11-17 17:23:18 UTC) #3
hahnjo
2 weeks, 5 days ago (2019-11-18 21:00:52 UTC) #4
LG
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b