Issue 553170043: Allow use of `libguile18.h` instead of `libguile.h`.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 553170043: Allow use of `libguile18.h` instead of `libguile.h`.

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 11 months ago by lemzwerg

Modified:
5 years, 11 months ago

Reviewers:
hahnjo

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Allow use of `libguile18.h` instead of `libguile.h`. This is for compilation on MacPorts, and I guess that more distributions will follow so that guile 1.8 and 2.x can be installed in parallel.

Patch Set 2 : Fix thinko. #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -7 lines)			Patch
M	aclocal.m4	View		1 chunk	+1 line, -1 line	0 comments	Download
M	config.hh.in	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	configure.ac	View	1	2 chunks	+15 lines, -3 lines	0 comments	Download
M	lily/include/lily-guile.hh	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	lily/include/ly-module.hh	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lily/include/mingw-compatibility.hh	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hahnjo

https://codereview.appspot.com/553170043/diff/554980043/lily/include/lily-guile.hh File lily/include/lily-guile.hh (right): https://codereview.appspot.com/553170043/diff/554980043/lily/include/lily-guile.hh#newcode29 lily/include/lily-guile.hh:29: #ifdef HAVE_LIBGUILE18_H I think this should be `#if HAVE_LIBGUILE18_H` ...

5 years, 11 months ago (2019-11-17 17:13:37 UTC) #1

lemzwerg

> I think this should be `#if HAVE_LIBGUILE18_H` because it's > always defined AFAICS. This ...

5 years, 11 months ago (2019-11-17 17:17:23 UTC) #2

LG

Expand All Messages | Collapse All Messages