Issue 5530067: Fix for Issue 11: Automatic cookie handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5530067: Fix for Issue 11: Automatic cookie handling

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by imturner

Modified:
11 years, 2 months ago

Reviewers:
jcgregorio, dimo414

CC:
httplib2-dev_googlegroups.com

Visibility:
Public.

More Reviews

Patch Set 1 #

Patch Set 2 : Port fix for Issue 11 to python3 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1113 lines, -4 lines)			Patch
	M	python2/httplib2/__init__.py	View		7 chunks	+543 lines, -1 line	0 comments	Download
	M	python3/httplib2/__init__.py	View	1	8 chunks	+570 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

imturner

This patch adds functionality for automatically handling cookies (Issue 11)

12 years, 3 months ago (2012-01-10 22:12:06 UTC) #1

dimo414_gmail.com

11 years, 2 months ago (2013-02-20 04:50:40 UTC) #3

Did anything ever come of this?  The patch no longer applies cleanly to 
7.7.  A quick test indicates it works against 7.4, but fails to apply to 
7.5.

Is there any interest in getting this into the project?  I feel it would be 
a very powerful addition.  I for one am very grateful this patch exists, 
and wish it were in the project proper.  If people want, I'll figure out 
what's needed to make this work with 7.7 (I imagine not much) and post an 
updated patch.

Michael

On Tuesday, January 10, 2012 10:11:31 PM UTC-5, Ian wrote:
>
> Fixing typo in dev mailing list address. Oops.
>
> http://codereview.appspot.com/5530067/
>

Expand All Messages | Collapse All Messages