Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(373)

Issue 5529048: Gets rid of PostScript in bar-chords-notation-for-guitar--with-text-spanner.ly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by MikeSol
Modified:
2 years, 2 months ago
Reviewers:
Graham Percival, mail
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Gets rid of PostScript in bar-chords-notation-for-guitar--with-text-spanner.ly

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -37 lines) Patch
M Documentation/snippets/bar-chords-notation-for-guitar--with-text-spanner.ly View 3 chunks +6 lines, -17 lines 0 comments Download
M Documentation/snippets/formatting-lyrics-syllables.ly View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/snippets/hymn-template.ly View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/snippets/new/bar-chords-notation-for-guitar--with-text-spanner.ly View 3 chunks +5 lines, -16 lines 0 comments Download
M Documentation/snippets/partcombine-and-autobeamoff.ly View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4
MikeSol
This patch compiles clean and allows me to finish a doc build (which is currently ...
2 years, 3 months ago #1
Graham Percival
LGTM I'm vaguely curious as to what's the difference between this postscript and the regtest ...
2 years, 3 months ago #2
mail_philholmes.net
----- Original Message ----- From: <graham@percival-music.ca> To: <mtsolo@gmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Monday, January 09, ...
2 years, 3 months ago #3
Graham Percival
2 years, 3 months ago #4
On Mon, Jan 09, 2012 at 02:24:45PM -0000, Phil Holmes wrote:
> It
> actually looks like the only substantive change if with the
Documentation/snippets/bar-chords-notation-for-guitar--with-text-spanner.ly
> which is duplicated in snippets/new.  Mike - you only need to edit
> the one in snippets/new - the other should be updated in the LSR,
> and it will appear in snippets/ when an LSR import is run.

Correct in general, but the overall goal is to let Mike build the
docs again.  As such, I think it's appropriate to dump the change
in snippets/new/ and run makelsr himself.  If this was just a doc
clarification, then I'd suggest it be done the other way.

> If this sounds right - I can do the edit and will do the import at
> some time.  There's also 3 other files with essentially null changes
> to them - might be a cleaner patch if you get rid of these.

Yes... the git history would be slightly more clear if he did a
local makelsr, then changed the one file in snippets/new/, then
did another local makelsr.  But in this case I didn't think it was
worth asking for that level of bureaucracy.

- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5