Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(392)

Issue 55210044: Ignore inodes when generating etags.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by benji
Modified:
10 years, 3 months ago
Reviewers:
mp+202542, benji-york
Visibility:
Public.

Description

Ignore inodes when generating etags. Since the inode for a given file will vary across servers, using inode to generate etags when there are multiple back-end servers means that the etags for a given URL will vary depending on which back-end fulfilled the request. https://code.launchpad.net/~benji/charms/precise/juju-gui/make-etags-ignore-inode/+merge/202542 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Ignore inodes when generating etags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M config/apache-site.template View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
benji
Please take a look.
10 years, 3 months ago (2014-01-21 19:52:59 UTC) #1
benji-york
LGTMMAI (looks good to me, myself, and I)
10 years, 3 months ago (2014-01-21 20:25:16 UTC) #2
benji
10 years, 3 months ago (2014-01-21 20:28:33 UTC) #3
*** Submitted:

Ignore inodes when generating etags.

Since the inode for a given file will vary across servers, using inode to
generate etags when there are multiple back-end servers means that the etags
for a given URL will vary depending on which back-end fulfilled the request.

R=benji-york
CC=
https://codereview.appspot.com/55210044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b