Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(346)

Issue 551730043: make_draw_bezier_boxes: save work if thickness == 0.0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by hanwenn
Modified:
3 years, 11 months ago
Reviewers:
Dan Eble, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

make_draw_bezier_boxes: save work if thickness == 0.0 This drop make_draw_bezier_boxes from 0.73% to 0.44% in the profile for MSDM

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M lily/stencil-integral.cc View 3 chunks +24 lines, -5 lines 1 comment Download

Messages

Total messages: 5
Dan Eble
I see I'm late to the party with this comment, but what are the error ...
3 years, 11 months ago (2020-04-24 18:30:08 UTC) #1
hanwenn
The percentages between different have looked fairly repeatable, but as a less invasive measure is ...
3 years, 11 months ago (2020-04-24 18:44:05 UTC) #2
dak
https://codereview.appspot.com/551730043/diff/583770043/lily/stencil-integral.cc File lily/stencil-integral.cc (right): https://codereview.appspot.com/551730043/diff/583770043/lily/stencil-integral.cc#newcode496 lily/stencil-integral.cc:496: break; I think that is less readable than desirable. ...
3 years, 11 months ago (2020-04-24 18:56:31 UTC) #3
hanwenn
On Fri, Apr 24, 2020 at 8:56 PM <dak@gnu.org> wrote: > > > https://codereview.appspot.com/551730043/diff/583770043/lily/stencil-integral.cc > ...
3 years, 11 months ago (2020-04-24 21:06:07 UTC) #4
hanwenn
3 years, 11 months ago (2020-05-02 22:26:38 UTC) #5
commit fadb710df7ed135d7712ce50fcdfa83a89753213
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Fri Apr 17 20:20:50 2020 +0200

    make_draw_bezier_boxes: save work if thickness == 0.0
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b