Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(132)

Issue 551640043: Issue 5862: Prefer astyle 3.1 and update clang-format options (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by Dan Eble
Modified:
6 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5862/ Change the preferred version of astyle from 2.04 to 3.1. In a separate commit, add a few clang-format options to reduce (slightly) the extent of changes that a subsequent fixcc.py makes. Test procedure: 1. clang-format everything (version 9.0.0) 2. git commit 3. fixcc.py everything (astyle version 3.1) 4. git diff | wc -l BASELINE LINES master@786c3669ff08804465a89013d349fc745fd783c9 19702 BENEFICIAL OPTIONS (TESTED INDIVIDUALLY) LINES ConstructorInitializerIndentWidth: 2 19062 ContinuationIndentWidth: 2 15018 SpaceAfterCStyleCast: true 19540 [Tested together] 14171 OTHER OPTIONS (TESTED INDIVIDUALLY) LINES AlignEscapedNewlines: Left 19702 AlignOperands: false 20760 AllowShortFunctionsOnASingleLine: InlineOnly 19708 AlwaysBreakTemplateDeclarations: MultiLine 19702 BinPackArguments: false 21588 BinPackParameters: false 20557 BreakBeforeTernaryOperators: true 19702 BreakConstructorInitializers: BeforeColon 19702 BreakInheritanceList: BeforeColon 19702 ColumnLimit: 80 19702 SortIncludes: false 19702 SpaceAfterTemplateKeyword: false 19702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M .clang-format View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/auxiliar/fixcc.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
Dan Eble
It's worth emphasizing this: even with these improvements to the clang-format configuration, those who use ...
6 months, 1 week ago (2020-03-26 01:25:57 UTC) #1
dak
On 2020/03/26 01:25:57, Dan Eble wrote: > It's worth emphasizing this: even with these improvements ...
6 months ago (2020-03-26 11:35:11 UTC) #2
Dan Eble
6 months ago (2020-03-26 23:17:17 UTC) #3
On 2020/03/26 11:35:11, dak wrote:
> On 2020/03/26 01:25:57, Dan Eble wrote:
> > It's worth emphasizing this: even with these improvements to the
clang-format
> > configuration, those who use clang-format will introduce a truckload of
> > differences from the traditional indentation.
...
> correctly.  Is there some reasonable hope that we could boil down a "common
> denominator" style where alternately applying clang formatting and fixcc would
> end up with a fixed end result rather than some cycle?

I have not familiarized myself with the options of astyle, but at present, I'm
not optimistic.

Still, as I worked on this change, I noticed a couple of common and simple
things that could take another bite out of the differences:

1. space or no space after the "operator" keyword
2. space or no space after "template" in "template<class T>"
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b