Issue 55160043: code review 55160043: liblink: remove use of linkmode on ARM

Issue 55160043: code review 55160043: liblink: remove use of linkmode on ARM (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
dave, iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

liblink: remove use of linkmode on ARM Now that liblink is compiled into the compilers and assemblers, it must not refer to the "linkmode", since that is not known until link time. This CL makes the ARM support no longer use linkmode, which fixes a bug with cgo binaries that contain their own TLS variables. The x86 code must also remove linkmode; that is issue 7164. Fixes issue 6992.

Patch Set 1 #

Patch Set 2 : diff -r 3a08deffa322 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3a08deffa322 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 619cbfc6f3e2 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 5 : diff -r cd8f9679d5f1 https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -72 lines)			Patch
M	src/cmd/ld/data.c	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/liblink/asm5.c	View	1 2 3 4	8 chunks	+9 lines, -11 lines	0 comments	Download
M	src/liblink/obj5.c	View	1 2 3 4	7 chunks	+58 lines, -58 lines	0 comments	Download
M	src/pkg/runtime/asm_arm.s	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2014-01-21 18:41:20 UTC) #1

iant

LGTM https://codereview.appspot.com/55160043/diff/60001/src/liblink/obj5.c File src/liblink/obj5.c (right): https://codereview.appspot.com/55160043/diff/60001/src/liblink/obj5.c#newcode403 src/liblink/obj5.c:403: p->scond = 14; s/14/C_SCOND_NONE/ ? https://codereview.appspot.com/55160043/diff/60001/src/liblink/obj5.c#newcode414 src/liblink/obj5.c:414: p->scond ...

11 years, 3 months ago (2014-01-21 19:15:57 UTC) #2

rsc

https://codereview.appspot.com/55160043/diff/60001/src/liblink/obj5.c File src/liblink/obj5.c (right): https://codereview.appspot.com/55160043/diff/60001/src/liblink/obj5.c#newcode403 src/liblink/obj5.c:403: p->scond = 14; On 2014/01/21 19:15:57, iant wrote: > ...

11 years, 3 months ago (2014-01-21 20:52:42 UTC) #3

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=eee3e7a93639 *** liblink: remove use of linkmode on ARM Now that liblink ...

11 years, 3 months ago (2014-01-22 00:46:37 UTC) #4

dave_cheney.net

11 years, 3 months ago (2014-01-22 04:34:15 UTC) #5

Message was sent while issue was closed.

I think this has broken all the arm builders.

The are all timing out in misc/cgo/test. 

http://build.golang.org/log/66debb81d8b71d52b4d32098c177f1e0204364d4

Expand All Messages | Collapse All Messages