Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(880)

Issue 551590044: aclocal.m4: Update PKG_* macros to pkg-config 0.29.2

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by lemzwerg
Modified:
4 months ago
Reviewers:
hahnjo, hanwenn
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

aclocal.m4: Update PKG_* macros to pkg-config 0.29.2 This commit removes the old definition of PKG_CHECK_MODULES (from 2004) and simply appends a recent version of pkg-config's file `pkg.m4` at the end of `aclocal.m4`. This immediately improves documentation of pkg-config stuff. Now the list of environment variables shown in `configure --help` ends with PKG_CONFIG path to pkg-config utility PKG_CONFIG_PATH directories to add to pkg-config's search path PKG_CONFIG_LIBDIR path overriding pkg-config's built-in search path GUILE_CFLAGS C compiler flags for GUILE, overriding pkg-config GUILE_LIBS linker flags for GUILE, overriding pkg-config BDWGC_CFLAGS C compiler flags for BDWGC, overriding pkg-config BDWGC_LIBS linker flags for BDWGC, overriding pkg-config PANGO_FT2_CFLAGS C compiler flags for PANGO_FT2, overriding pkg-config PANGO_FT2_LIBS linker flags for PANGO_FT2, overriding pkg-config FONTCONFIG_CFLAGS C compiler flags for FONTCONFIG, overriding pkg-config FONTCONFIG_LIBS linker flags for FONTCONFIG, overriding pkg-config FREETYPE2_CFLAGS C compiler flags for FREETYPE2, overriding pkg-config FREETYPE2_LIBS linker flags for FREETYPE2, overriding pkg-config GLIB_CFLAGS C compiler flags for GLIB, overriding pkg-config GLIB_LIBS linker flags for GLIB, overriding pkg-config GOBJECT_CFLAGS C compiler flags for GOBJECT, overriding pkg-config GOBJECT_LIBS linker flags for GOBJECT, overriding pkg-config

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -54 lines) Patch
M aclocal.m4 View 1 2 chunks +277 lines, -54 lines 0 comments Download

Messages

Total messages: 4
hanwenn
https://codereview.appspot.com/551590044/diff/553640043/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/551590044/diff/553640043/aclocal.m4#newcode1127 aclocal.m4:1127: # pkg.m4 - Macros to locate and utilise pkg-config. ...
4 months ago (2020-03-07 09:32:47 UTC) #1
hahnjo
The update LGTM On 2020/03/07 09:32:47, hanwenn wrote: > https://codereview.appspot.com/551590044/diff/553640043/aclocal.m4 > File aclocal.m4 (right): > ...
4 months ago (2020-03-07 09:36:25 UTC) #2
lemzwerg
> > can we include this rather than copy & paste? > > This would ...
4 months ago (2020-03-07 09:46:48 UTC) #3
lemzwerg
4 months ago (2020-03-07 14:11:18 UTC) #4
rebase
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b