Issue 55140043: code review 55140043: misc/cgo/testtls: make test less flaky

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55140043: code review 55140043: misc/cgo/testtls: make test less flaky (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rsc

Modified:
11 years, 1 month ago

Reviewers:
r, iant

CC:
iant, r, dave_cheney.net, golang-codereviews

Visibility:
Public.

Description

misc/cgo/testtls: make test less flaky Now it should always fail on ARM. (The fix is on its way too.)

Patch Set 2 : diff -r 3a08deffa322 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3a08deffa322 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 27dcbbb2fd4e https://code.google.com/p/go/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	misc/cgo/testtls/tls.go	View	1 2 3	1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello iant, r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 1 month ago (2014-01-21 18:04:41 UTC) #1

dave_cheney.net

https://codereview.appspot.com/55140043/diff/40001/misc/cgo/testtls/tls.go File misc/cgo/testtls/tls.go (right): https://codereview.appspot.com/55140043/diff/40001/misc/cgo/testtls/tls.go#newcode28 misc/cgo/testtls/tls.go:28: t.Fatalf("at end, C.getTLS() = %#x, want %#x", keyVal, val, ...

11 years, 1 month ago (2014-01-21 21:54:23 UTC) #4

rsc

11 years, 1 month ago (2014-01-22 00:44:55 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=cd8f9679d5f1 ***

misc/cgo/testtls: make test less flaky

Now it should always fail on ARM.
(The fix is on its way too.)

R=iant, r, dave
CC=golang-codereviews
https://codereview.appspot.com/55140043

https://codereview.appspot.com/55140043/diff/40001/misc/cgo/testtls/tls.go
File misc/cgo/testtls/tls.go (right):

https://codereview.appspot.com/55140043/diff/40001/misc/cgo/testtls/tls.go#ne...
misc/cgo/testtls/tls.go:28: t.Fatalf("at end, C.getTLS() = %#x, want %#x",
keyVal, val, keyVal)
On 2014/01/21 21:54:23, dfc wrote:
> one too many values passed to Fatalf

Done.

Expand All Messages | Collapse All Messages