Issue 551400043: Docker base-image without pip

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 551400043: Docker base-image without pip

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 2 months ago by tjferrara

Modified:
4 years, 2 months ago

Reviewers:
deepikachander, alanmorales, yeliu

CC:
opt-crs_google.com

Visibility:
Public.

More Reviews

Description

The autoupdater's base image (google/cloud-sdk:slim) does not include pip, causing `pip install absl-py` to fail. Although pip3 is included for in the base-image, this python2 script requires a fresh install of python-pip to fix the issue. Note: I did not call apt-get update in order to save build time, but this may be required for long-term support.

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	autoupdate/Dockerfile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM, thanks so much Tyler!

Expand All Messages | Collapse All Messages