Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4816)

Issue 551210043: configure: Fix tests for compiler warning flags.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks ago by lemzwerg
Modified:
1 week ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

configure: Fix tests for compiler warning flags. `AC_LANG_PROGRAM` ignores compiler warnings. This behaviour made the tests always true and thus without any effect. We now add `-Werror` to enforce an error in case the warning flag is not known. To make that work it is also necessary to compile `confdefs.h` without warnings; we add a hack to undefine macro `PACKAGE_NAME`, which gets defined twice for historical reasons.

Patch Set 1 #

Patch Set 2 : Only change `confdefs.h`; the rest is already handled by issue #5608. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M aclocal.m4 View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
hahnjo
I don't think we should go this hacky way. For Clang I'm already fixing this ...
1 week, 6 days ago (2019-11-24 11:44:12 UTC) #1
lemzwerg
> I don't think we should go this hacky way. For Clang > I'm already ...
1 week, 6 days ago (2019-11-24 15:11:24 UTC) #2
lemzwerg
1 week ago (2019-11-30 14:42:39 UTC) #3
Only change `confdefs.h`; the rest is already handled by issue #5608.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b