Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 5504080: code review 5504080: cmd/go: two testing fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by rsc
Modified:
9 years, 1 month ago
Reviewers:
mikio
CC:
golang-dev, adg1
Visibility:
Public.

Description

cmd/go: two testing fixes 1. Show passing output for "go test" (no args) and with -v flag. 2. Warn about out-of-date packages being rebuilt.

Patch Set 1 #

Patch Set 2 : diff -r 13eb2c3e8a8f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 13eb2c3e8a8f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7287f60ba4e4 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -30 lines) Patch
M src/cmd/go/build.go View 1 2 chunks +24 lines, -15 lines 0 comments Download
M src/cmd/go/pkg.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/go/test.go View 1 6 chunks +45 lines, -14 lines 0 comments Download
M src/cmd/go/testflag.go View 1 2 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 1 month ago (2011-12-23 03:17:09 UTC) #1
adg1
LGTM
9 years, 1 month ago (2011-12-23 03:22:33 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=e029f0f2941f *** cmd/go: two testing fixes 1. Show passing output for "go ...
9 years, 1 month ago (2011-12-23 03:24:45 UTC) #3
mikio
9 years, 1 month ago (2011-12-23 03:26:13 UTC) #4
LGTM

"go test -v -file multicast_test.go -multicast" works fine.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b