Issue 5504080: code review 5504080: cmd/go: two testing fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5504080: code review 5504080: cmd/go: two testing fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rsc

Modified:
12 years, 4 months ago

Reviewers:
mikio

CC:
golang-dev, adg1

Visibility:
Public.

cmd/go: two testing fixes 1. Show passing output for "go test" (no args) and with -v flag. 2. Warn about out-of-date packages being rebuilt.

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -30 lines)			Patch
M	src/cmd/go/build.go	View	1	2 chunks	+24 lines, -15 lines	0 comments	Download
M	src/cmd/go/pkg.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1	6 chunks	+45 lines, -14 lines	0 comments	Download
M	src/cmd/go/testflag.go	View	1	2 chunks	+32 lines, -1 line	0 comments	Download

Total messages: 4

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 4 months ago (2011-12-23 03:17:09 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=e029f0f2941f *** cmd/go: two testing fixes 1. Show passing output for "go ...

12 years, 4 months ago (2011-12-23 03:24:45 UTC) #3

mikio

12 years, 4 months ago (2011-12-23 03:26:13 UTC) #4

LGTM

"go test -v -file multicast_test.go -multicast" works fine.