Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 5503044: Fix map initialization.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by niemeyer
Modified:
10 years, 7 months ago
Reviewers:
mp+86396
Visibility:
Public.

Description

https://code.launchpad.net/~niemeyer/goyaml/fix-map-init/+merge/86396 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix map initialization. #

Patch Set 3 : Fix map initialization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M decode.go View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M decode_test.go View 1 2 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 5
niemeyer
Please take a look.
10 years, 7 months ago (2011-12-20 13:34:17 UTC) #1
niemeyer
Please take a look.
10 years, 7 months ago (2011-12-20 13:37:27 UTC) #2
rog
LGTM https://codereview.appspot.com/5503044/diff/1/decode_test.go File decode_test.go (right): https://codereview.appspot.com/5503044/diff/1/decode_test.go#newcode86 decode_test.go:86: {"a: {b: c}", &struct{ A map[string]string }{map[string]string{"b": "c"}}}, ...
10 years, 7 months ago (2011-12-20 13:39:01 UTC) #3
niemeyer
https://codereview.appspot.com/5503044/diff/1/decode_test.go File decode_test.go (right): https://codereview.appspot.com/5503044/diff/1/decode_test.go#newcode86 decode_test.go:86: {"a: {b: c}", &struct{ A map[string]string }{map[string]string{"b": "c"}}}, > ...
10 years, 7 months ago (2011-12-20 13:42:47 UTC) #4
niemeyer
10 years, 7 months ago (2011-12-20 13:45:28 UTC) #5
*** Submitted:

Fix map initialization.

R=rog
CC=
https://codereview.appspot.com/5503044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b