Issue 55020045: Various Python2/3 compat issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55020045: Various Python2/3 compat issues

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by bcsaller

Modified:
10 years, 3 months ago

Reviewers:
mp+203885

Visibility:
Public.

Description

Various Python2/3 compat issues Also removes some dynamic module loading which didn't seem to add any value. https://code.launchpad.net/~bcsaller/amulet/fix-urlencode/+merge/203885 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -15 lines)			Patch
A	.bzrignore	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	amulet/charms/sentry/src/api.py	View	1 chunk	+4 lines, -11 lines	0 comments	Download
M	amulet/charms/sentry/src/modules/__init__.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	amulet/deployer.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	amulet/sentry.py	View	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Please take a look.

Expand All Messages | Collapse All Messages