Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 549840043: Simplify mf-to-table (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by hanwenn
Modified:
3 years, 11 months ago
Reviewers:
lemzwerg, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

mf-to-table: remove option handling Now, it just does /.log/.lisp/ to generate output filenames. This simplifies the Makefile. Update mf/GNUmakefile to match, and fix .tfm dependencies

Patch Set 1 #

Patch Set 2 : fix description #

Total comments: 4

Patch Set 3 : jonas' comments #

Patch Set 4 : make it actually work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -27 lines) Patch
M mf/GNUmakefile View 2 chunks +4 lines, -6 lines 0 comments Download
M scripts/build/mf-to-table.py View 1 2 3 2 chunks +6 lines, -21 lines 0 comments Download

Messages

Total messages: 7
hanwenn
fix description
3 years, 11 months ago (2020-04-11 15:40:12 UTC) #1
hahnjo
Thanks for the cleanup, a few nits inline. (I assume the description wasn't updated according ...
3 years, 11 months ago (2020-04-11 16:12:53 UTC) #2
hanwenn
jonas' comments
3 years, 11 months ago (2020-04-12 10:46:41 UTC) #3
hanwenn
updated description
3 years, 11 months ago (2020-04-12 10:47:19 UTC) #4
hanwenn
https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py File scripts/build/mf-to-table.py (right): https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py#newcode22 scripts/build/mf-to-table.py:22: import getopt On 2020/04/11 16:12:52, hahnjo wrote: > I ...
3 years, 11 months ago (2020-04-12 10:47:34 UTC) #5
hanwenn
make it actually work.
3 years, 11 months ago (2020-04-12 11:10:39 UTC) #6
lemzwerg
3 years, 11 months ago (2020-04-12 11:44:42 UTC) #7
LGTM (without testing)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b