Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(873)

Issue 549740043: Cleanup python/ build rules.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by hanwenn
Modified:
6 months, 1 week ago
Reviewers:
dan, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Cleanup python/ build rules. * Remove @ substitutions from python/*.py, making them directly importable from source. * Inline python-module stepmake template * Install __pycache__ files too; since the Python 3 transition, .pyc files weren't installed anymore. * Move relocate-preamble.py.in to scripts/ . This removes a implicit cross-directory (ie. broken) dependency. * Build python/ first; it's the basis for further scripts

Patch Set 1 #

Patch Set 2 : larger cleanup #

Patch Set 3 : make check passes #

Patch Set 4 : rebase on whitespace changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -81 lines) Patch
M GNUmakefile.in View 1 2 chunks +2 lines, -1 line 0 comments Download
M make/lilypond-vars.make View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M python/GNUmakefile View 1 1 chunk +16 lines, -7 lines 0 comments Download
M python/book_base_test.py View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M python/book_snippets.py View 1 1 chunk +1 line, -1 line 0 comments Download
M python/lilylib.py View 1 chunk +0 lines, -19 lines 0 comments Download
D python/relocate-preamble.py.in View 1 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/GNUmakefile View 1 1 chunk +3 lines, -1 line 0 comments Download
M scripts/abc2ly.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M scripts/convert-ly.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M scripts/etf2ly.py View 1 2 3 3 chunks +3 lines, -1 line 0 comments Download
M scripts/lilypond-book.py View 1 2 4 chunks +11 lines, -2 lines 0 comments Download
M scripts/midi2ly.py View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M scripts/musicxml2ly.py View 1 2 chunks +3 lines, -1 line 0 comments Download
A + scripts/relocate-preamble.py.in View 1 1 chunk +3 lines, -0 lines 0 comments Download
D stepmake/stepmake/python-module-rules.make View 1 1 chunk +0 lines, -10 lines 0 comments Download
D stepmake/stepmake/python-module-targets.make View 1 1 chunk +0 lines, -1 line 0 comments Download
D stepmake/stepmake/python-module-vars.make View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9
hahnjo
Could you please copy the comment to all places where you paste the code?
6 months, 1 week ago (2020-03-21 08:56:20 UTC) #1
hanwenn
On 2020/03/21 08:56:20, hahnjo wrote: > Could you please copy the comment to all places ...
6 months, 1 week ago (2020-03-21 09:47:34 UTC) #2
hanwenn
larger cleanup
6 months, 1 week ago (2020-03-21 11:15:23 UTC) #3
hanwenn
PTAL
6 months, 1 week ago (2020-03-21 11:16:12 UTC) #4
hahnjo
On 2020/03/21 11:16:12, hanwenn wrote: > PTAL Very please don't clutter diffs with unrelated whitespace ...
6 months, 1 week ago (2020-03-21 11:22:15 UTC) #5
hanwenn
make check passes
6 months, 1 week ago (2020-03-21 11:52:09 UTC) #6
hanwenn
On 2020/03/21 11:22:15, hahnjo wrote: > On 2020/03/21 11:16:12, hanwenn wrote: > > PTAL > ...
6 months, 1 week ago (2020-03-21 12:25:30 UTC) #7
hanwenn
rebase on whitespace changes
6 months, 1 week ago (2020-03-21 19:32:32 UTC) #8
dan_faithful.be
6 months, 1 week ago (2020-03-21 20:27:48 UTC) #9
On Mar 21, 2020, at 08:25, hanwenn@gmail.com wrote:
> 
> For context: many projects that I contribute to keep harping about
> trailing whitespace

I recently started using the ws-butler package to limit whitespace changes to
lines that also have substantive changes.  It has helped me.

https://github.com/lewang/ws-butler
— 
Dan

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b