Issue 5496072: Partially fix vertical text for Lion

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5496072: Partially fix vertical text for Lion

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by caryclark1

Modified:
12 years, 4 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This fixes vertical text with Lion for full fonts and monospaced fonts requiring glyph bounds calculations, but not rotated vertical text. The latter will be fixed in a future CL.

Patch Set 1 #

Patch Set 2 : fix indentation #

Total comments: 1

Patch Set 3 : add comment #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
	M	src/ports/SkFontHost_mac_coretext.cpp	View	1 2	3 chunks	+21 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

12 years, 4 months ago (2011-12-19 14:29:25 UTC) #2

ltgm with suggested comment

http://codereview.appspot.com/5496072/diff/1001/src/ports/SkFontHost_mac_core...
File src/ports/SkFontHost_mac_coretext.cpp (right):

http://codereview.appspot.com/5496072/diff/1001/src/ports/SkFontHost_mac_core...
src/ports/SkFontHost_mac_coretext.cpp:934: if (fVertical) {
Maybe a comment above the if (fVertical) like...

/*
To work around apparent bugs (between lion and pre-lion), we have to change
which font we query for bounds when working with vertical text.
*/

Expand All Messages | Collapse All Messages