Issue 5496045: goyaml: fixes for weekly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5496045: goyaml: fixes for weekly

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rog

Modified:
12 years, 4 months ago

Reviewers:
mp+85889, niemeyer

Visibility:
Public.

Description

gofix + rune conversion. https://code.launchpad.net/~rogpeppe/goyaml/goyaml-rune-changes/+merge/85889 (do not edit description out of merge proposal)

Patch Set 2 : goyaml: fixes for weekly #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	encode.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	goyaml.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	resolve.go	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/5496045/diff/1/goyaml.go File goyaml.go (right): https://codereview.appspot.com/5496045/diff/1/goyaml.go#newcode200 goyaml.go:200: case rune('c'): Do we really need the typing ...

12 years, 4 months ago (2011-12-15 16:04:51 UTC) #2

rog

On 2011/12/15 16:04:51, niemeyer wrote: > LGTM > > https://codereview.appspot.com/5496045/diff/1/goyaml.go > File goyaml.go (right): > ...

12 years, 4 months ago (2011-12-15 16:18:01 UTC) #4

LGTM

Expand All Messages | Collapse All Messages