Issue 54950045: Add an unreachable code elimintation in the Optimizer.

Issue 54950045: Add an unreachable code elimintation in the Optimizer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by etienneb

Modified:
10 years, 2 months ago

Reviewers:
chrisha

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Adds an unreachable code elimintation in the Optimizer. R=chrisha@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=2020

Patch Set 2 : unittest draft #

Patch Set 5 : nits #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+308 lines, -1 line)			Patch
M	syzygy/optimize/optimize.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	syzygy/optimize/optimize_app.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	syzygy/optimize/optimize_app.cc	View	1	7 chunks	+12 lines, -0 lines	0 comments	Download
A	syzygy/optimize/transforms/unreachable_block_transform.h	View	1 2 3 4	1 chunk	+66 lines, -0 lines	0 comments	Download
A	syzygy/optimize/transforms/unreachable_block_transform.cc	View	1	1 chunk	+89 lines, -0 lines	0 comments	Download
A	syzygy/optimize/transforms/unreachable_block_transform_unittest.cc	View	1 2 3	1 chunk	+135 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

chrisha

Nice! lgtm with nits! https://codereview.appspot.com/54950045/diff/90001/syzygy/optimize/transforms/unreachable_block_transform.h File syzygy/optimize/transforms/unreachable_block_transform.h (right): https://codereview.appspot.com/54950045/diff/90001/syzygy/optimize/transforms/unreachable_block_transform.h#newcode20 syzygy/optimize/transforms/unreachable_block_transform.h:20: // The transform operates in ...

10 years, 2 months ago (2014-02-03 18:08:01 UTC) #2

etienneb

done. Committing... https://codereview.appspot.com/54950045/diff/90001/syzygy/optimize/transforms/unreachable_block_transform.h File syzygy/optimize/transforms/unreachable_block_transform.h (right): https://codereview.appspot.com/54950045/diff/90001/syzygy/optimize/transforms/unreachable_block_transform.h#newcode20 syzygy/optimize/transforms/unreachable_block_transform.h:20: // The transform operates in two phase. ...

10 years, 2 months ago (2014-02-03 18:13:04 UTC) #3

etienneb

10 years, 2 months ago (2014-02-03 18:20:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r2020 (presubmit successful).

Expand All Messages | Collapse All Messages