Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1000)

Issue 549350043: Cleanup initialization of configure process (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by hahnjo
Modified:
5 months, 3 weeks ago
Reviewers:
dak, dan, Dan Eble, c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Cleanup initialization of configure process Individual changes: 1. Cleanup directory handling in STEPMAKE_INIT * Get rid of code which configures the Stepmake package, that hasn't been supported for a long time. * Replace $ugh_ugh_autoconf250_builddir by $ac_pwd and @abs_builddi@. I think the latter is actually more correct, but $ac_abs_builddir not available when executing configure. * Replace hacks around $srcdir and @srcdir@ by predefined variables. 2. Drop unused MICRO_VERSION 3. Call AC_INIT correctly with all parameters Version information via m4_esyscmd() by David K. 4. Remove passing of package variables

Patch Set 1 #

Total comments: 1

Patch Set 2 : Take information from VERSION #

Patch Set 3 : Workaround for read-only source directories #

Total comments: 1

Patch Set 4 : Use m4_esyscmd_s + echo without -n #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -157 lines) Patch
M Documentation/contributor/build-notes.itexi View 1 2 5 chunks +34 lines, -35 lines 0 comments Download
M VERSION View 1 chunk +0 lines, -1 line 0 comments Download
M aclocal.m4 View 1 4 chunks +6 lines, -95 lines 0 comments Download
M autogen.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M config.hh.in View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M config.make.in View 4 chunks +5 lines, -7 lines 0 comments Download
M configure.ac View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M make/stepmake.make View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M make/substitute.make View 2 chunks +0 lines, -3 lines 0 comments Download
M po/GNUmakefile View 1 chunk +2 lines, -2 lines 0 comments Download
M stepmake/stepmake/c++-vars.make View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M stepmake/stepmake/executable-vars.make View 1 chunk +1 line, -1 line 0 comments Download
M stepmake/stepmake/generic-vars.make View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 46
dak
https://codereview.appspot.com/549350043/diff/581410043/configure.ac File configure.ac (right): https://codereview.appspot.com/549350043/diff/581410043/configure.ac#newcode7 configure.ac:7: AC_INIT([LilyPond], [2.21.0], [bug-lilypond@gnu.org], [lilypond], [http://lilypond.org/]) Hardwiring the version number ...
6 months ago (2020-01-08 16:18:25 UTC) #1
hahnjo
On 2020/01/08 16:18:25, dak wrote: > https://codereview.appspot.com/549350043/diff/581410043/configure.ac > File configure.ac (right): > > https://codereview.appspot.com/549350043/diff/581410043/configure.ac#newcode7 > ...
6 months ago (2020-01-08 16:22:32 UTC) #2
dak
jonas.hahnfeld@gmail.com writes: > Reviewers: dak, > > Message: > On 2020/01/08 16:18:25, dak wrote: >> ...
6 months ago (2020-01-08 16:43:24 UTC) #3
hahnjo
On 2020/01/08 16:43:24, dak wrote: > mailto:jonas.hahnfeld@gmail.com writes: > > > Reviewers: dak, > > ...
6 months ago (2020-01-08 17:48:36 UTC) #4
dak
On 2020/01/08 17:48:36, hahnjo wrote: > On 2020/01/08 16:43:24, dak wrote: > > mailto:jonas.hahnfeld@gmail.com writes: ...
6 months ago (2020-01-08 18:03:36 UTC) #5
hahnjo
On 2020/01/08 18:03:36, dak wrote: > On 2020/01/08 17:48:36, hahnjo wrote: > > On 2020/01/08 ...
6 months ago (2020-01-08 18:09:53 UTC) #6
hahnjo
On 2020/01/08 18:09:53, hahnjo wrote: > On 2020/01/08 18:03:36, dak wrote: > > On 2020/01/08 ...
6 months ago (2020-01-08 18:10:50 UTC) #7
dak
On 2020/01/08 18:03:36, dak wrote: > > > > But re-reading your question, you're maybe ...
6 months ago (2020-01-08 18:48:10 UTC) #8
c_sorensen
How about AC_INIT([LilyPond],m4_esyscmd(echo `VERSION.AC')) The documentation says it is permissible to use m4_esyscmd as part ...
6 months ago (2020-01-08 19:40:06 UTC) #9
hahnjo
On 2020/01/08 19:40:06, c_sorensen wrote: > How about > > AC_INIT([LilyPond],m4_esyscmd(echo `VERSION.AC')) > > The ...
6 months ago (2020-01-08 19:49:22 UTC) #10
dak
On 2020/01/08 19:49:22, hahnjo wrote: > On 2020/01/08 19:40:06, c_sorensen wrote: > > How about ...
6 months ago (2020-01-08 20:14:20 UTC) #11
c_sorensen
What documentation says AC_INIT should be called with constant arguments? Quoting from https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Initializing-configure.html "The arguments ...
6 months ago (2020-01-08 20:15:10 UTC) #12
hahnjo
On 2020/01/08 20:14:20, dak wrote: > On 2020/01/08 19:49:22, hahnjo wrote: > > On 2020/01/08 ...
6 months ago (2020-01-08 20:30:20 UTC) #13
c_sorensen
On 1/8/20, 1:30 PM, "jonas.hahnfeld@gmail.com" <jonas.hahnfeld@gmail.com> wrote: looks like I confused / misunderstood some other ...
6 months ago (2020-01-08 20:39:05 UTC) #14
dak
On 2020/01/08 20:30:20, hahnjo wrote: > On 2020/01/08 20:14:20, dak wrote: > > On 2020/01/08 ...
6 months ago (2020-01-08 20:46:37 UTC) #15
hahnjo
Take information from VERSION
6 months ago (2020-01-08 21:08:58 UTC) #16
hahnjo
On 2020/01/08 20:46:37, dak wrote: > On 2020/01/08 20:30:20, hahnjo wrote: > > On 2020/01/08 ...
6 months ago (2020-01-08 21:11:00 UTC) #17
hahnjo
Is this ok to push in its current revision?
5 months, 4 weeks ago (2020-01-14 13:52:02 UTC) #18
dak
On 2020/01/14 13:52:02, hahnjo wrote: > Is this ok to push in its current revision? ...
5 months, 4 weeks ago (2020-01-14 13:59:43 UTC) #19
hahnjo
On 2020/01/14 13:59:43, dak wrote: > On 2020/01/14 13:52:02, hahnjo wrote: > > Is this ...
5 months, 4 weeks ago (2020-01-14 14:12:47 UTC) #20
Dan Eble
On 2020/01/14 13:59:43, dak wrote: > On 2020/01/14 13:52:02, hahnjo wrote: > I am not ...
5 months, 4 weeks ago (2020-01-14 14:29:38 UTC) #21
dak
On 2020/01/14 14:12:47, hahnjo wrote: > On 2020/01/14 13:59:43, dak wrote: > > On 2020/01/14 ...
5 months, 4 weeks ago (2020-01-14 14:37:21 UTC) #22
hahnjo
On 2020/01/14 14:29:38, Dan Eble wrote: > On 2020/01/14 13:59:43, dak wrote: > > On ...
5 months, 4 weeks ago (2020-01-14 14:43:34 UTC) #23
Dan Eble
On 2020/01/14 14:43:34, hahnjo wrote: > On 2020/01/14 14:29:38, Dan Eble wrote: > > On ...
5 months, 4 weeks ago (2020-01-14 14:48:44 UTC) #24
dak
On 2020/01/14 14:48:44, Dan Eble wrote: > On 2020/01/14 14:43:34, hahnjo wrote: > > On ...
5 months, 4 weeks ago (2020-01-14 15:07:48 UTC) #25
Dan Eble
Jonas, If you want to push this in a form where the only thing lacking ...
5 months, 4 weeks ago (2020-01-14 15:08:59 UTC) #26
dak
On 2020/01/14 15:07:48, dak wrote: > On 2020/01/14 14:48:44, Dan Eble wrote: > > On ...
5 months, 4 weeks ago (2020-01-14 15:19:09 UTC) #27
dak
On 2020/01/14 15:19:09, dak wrote: > On 2020/01/14 15:07:48, dak wrote: > > On 2020/01/14 ...
5 months, 4 weeks ago (2020-01-14 15:54:28 UTC) #28
Dan Eble
On 2020/01/14 15:54:28, dak wrote: > +AC_INIT([LilyPond], > + [m4_esyscmd_s([. ${SRCDIR:-.}/VERSION; echo I was about ...
5 months, 4 weeks ago (2020-01-14 16:35:50 UTC) #29
Dan Eble
On 2020/01/14 16:35:50, Dan Eble wrote: > On 2020/01/14 15:54:28, dak wrote: > > +AC_INIT([LilyPond], ...
5 months, 4 weeks ago (2020-01-14 16:59:52 UTC) #30
dak
On 2020/01/14 16:35:50, Dan Eble wrote: > On 2020/01/14 15:54:28, dak wrote: > > +AC_INIT([LilyPond], ...
5 months, 4 weeks ago (2020-01-14 17:20:53 UTC) #31
hahnjo
Workaround for read-only source directories
5 months, 4 weeks ago (2020-01-14 18:14:56 UTC) #32
hahnjo
On 2020/01/14 15:54:28, dak wrote: > Well, how about > diff --git a/autogen.sh b/autogen.sh > ...
5 months, 4 weeks ago (2020-01-14 18:21:32 UTC) #33
Dan Eble
Let me try to recount all the factors that did or do contribute to my ...
5 months, 4 weeks ago (2020-01-14 20:10:34 UTC) #34
Dan Eble
On 2020/01/14 18:21:32, hahnjo wrote: > Dan, if you don't want to run autogen.sh with ...
5 months, 4 weeks ago (2020-01-14 21:56:24 UTC) #35
hahnjo
On 2020/01/14 21:56:24, Dan Eble wrote: > On 2020/01/14 18:21:32, hahnjo wrote: > > Dan, ...
5 months, 4 weeks ago (2020-01-15 08:08:26 UTC) #36
dan_faithful.be
On Jan 15, 2020, at 03:08, jonas.hahnfeld@gmail.com wrote: > > Maybe I misunderstood your process; ...
5 months, 4 weeks ago (2020-01-15 13:50:29 UTC) #37
hahnjo
On 2020/01/15 13:50:29, dan_faithful.be wrote: > On Jan 15, 2020, at 03:08, mailto:jonas.hahnfeld@gmail.com wrote: > ...
5 months, 4 weeks ago (2020-01-15 14:00:15 UTC) #38
dan_faithful.be
On Jan 15, 2020, at 09:00, jonas.hahnfeld@gmail.com wrote: > What's causing problems is that the ...
5 months, 4 weeks ago (2020-01-15 14:36:29 UTC) #39
hahnjo
Assuming no further comments, I'm planning to push this later today (evening CET).
5 months, 3 weeks ago (2020-01-16 08:38:30 UTC) #40
dak
https://codereview.appspot.com/549350043/diff/545440043/configure.ac File configure.ac (right): https://codereview.appspot.com/549350043/diff/545440043/configure.ac#newcode8 configure.ac:8: [m4_esyscmd([. ${SRCDIR:-.}/VERSION; echo -n $MAJOR_VERSION.$MINOR_VERSION.$PATCH_LEVEL])], The proposal using m4_esyscmd_s ...
5 months, 3 weeks ago (2020-01-16 10:57:46 UTC) #41
hahnjo
On 2020/01/16 10:57:46, dak wrote: > https://codereview.appspot.com/549350043/diff/545440043/configure.ac > File configure.ac (right): > > https://codereview.appspot.com/549350043/diff/545440043/configure.ac#newcode8 > ...
5 months, 3 weeks ago (2020-01-16 11:22:24 UTC) #42
dak
On 2020/01/16 11:22:24, hahnjo wrote: > On 2020/01/16 10:57:46, dak wrote: > > https://codereview.appspot.com/549350043/diff/545440043/configure.ac > ...
5 months, 3 weeks ago (2020-01-16 13:24:21 UTC) #43
hahnjo
Use m4_esyscmd_s + echo without -n
5 months, 3 weeks ago (2020-01-16 16:06:47 UTC) #44
Dan Eble
I've run some builds with a writable source directory, and I'm fine with it. Feel ...
5 months, 3 weeks ago (2020-01-17 07:35:45 UTC) #45
hahnjo
5 months, 3 weeks ago (2020-01-17 08:12:06 UTC) #46
On 2020/01/17 07:35:45, Dan Eble wrote:
> I've run some builds with a writable source directory, and I'm fine with it. 
> Feel free to move forward with the cleaner change.  I'll submit a LilyDev pull
> request to cope with it.

I'm not going to change this patch once more. We can keep it in mind for future
changes though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b