Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5714)

Issue 5493082: initial impl for imagefilters (incomplete)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by reed1
Modified:
12 years, 4 months ago
Reviewers:
Stephen White
CC:
bsalomon, caryclark1, senorblanco
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : need to impl factories so that picture testing works #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+590 lines, -7 lines) Patch
A gm/testimagefilters.cpp View 1 1 chunk +117 lines, -0 lines 0 comments Download
M gyp/effects.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImageFilter.h View 1 3 chunks +22 lines, -2 lines 0 comments Download
A include/effects/SkTestImageFilters.h View 1 1 chunk +120 lines, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +15 lines, -1 line 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +17 lines, -4 lines 0 comments Download
A src/effects/SkTestImageFilters.cpp View 1 1 chunk +297 lines, -0 lines 1 comment Download

Messages

Total messages: 4
reed1
My first cut at plumbing in imagefilters 1. only invoked during saveLayer/restore right now. I ...
12 years, 4 months ago (2011-12-19 19:06:55 UTC) #1
reed1
12 years, 4 months ago (2011-12-19 22:16:48 UTC) #2
Stephen White
Let's split out these sample filters into a separate patch, and just land the glue ...
12 years, 4 months ago (2011-12-20 16:26:48 UTC) #3
reed1
12 years, 4 months ago (2011-12-20 16:29:09 UTC) #4
I definitely want to keep them, as they seem logical building blocks for other
effects, and we want this skia feature (imagefilters) to make sense on its own,
and not solely in conjunction with webkit's current svg impl.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b