Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(134)

Issue 5493043: faster es53: cajaVM.def edition (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by felix8a
Modified:
14 years, 10 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This change reduces startup time of a minimal gadget from ~1800ms to ~1100ms in Chrome Beta (16.0) This change is mostly about speeding up cajaVM.def(), mainly by changing a recursive implementation to an iterative one. cajaVM.def also ends up invoking Object.prototype.ownKeys___ whitelistAll and this change speeds those up by using Object.keys when possible, and inlining some tests.

Patch Set 1 #

Patch Set 2 : faster es53: cajaVM.def edition #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -39 lines) Patch
M src/com/google/caja/es53.js View 1 6 chunks +43 lines, -38 lines 0 comments Download
M src/com/google/caja/plugin/domado.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
felix8a
14 years, 10 months ago (2011-12-15 01:04:42 UTC) #1
metaweta
LGTM http://codereview.appspot.com/5493043/diff/2001/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): http://codereview.appspot.com/5493043/diff/2001/src/com/google/caja/plugin/domado.js#newcode330 src/com/google/caja/plugin/domado.js:330: //cajaVM.def(method); // unnecessary in theory. TODO(felix8a): verify If ...
14 years, 10 months ago (2011-12-15 16:58:48 UTC) #2
felix8a
14 years, 10 months ago (2011-12-15 17:47:32 UTC) #3
@r4689
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b