Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 5492043: Expose baseURI and unabsolutified uris to URI policies (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by Jasvir
Modified:
14 years, 9 months ago
Reviewers:
felix8a, Jasvir Nagra
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Expose baseUri and unresolved uris in external references so uri policies can switch on actual uris that appear in a page. @4685

Patch Set 1 #

Total comments: 6

Patch Set 2 : Expose baseURI and unabsolutified uris to URI policies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java View 1 1 chunk +6 lines, -7 lines 0 comments Download
M src/com/google/caja/lexer/ExternalReference.java View 1 1 chunk +16 lines, -1 line 0 comments Download
M src/com/google/caja/parser/quasiliteral/ModuleManager.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/CssRewriter.java View 2 chunks +6 lines, -4 lines 0 comments Download
M src/com/google/caja/plugin/stages/InlineCssImportsStage.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
Jasvir
14 years, 10 months ago (2011-12-15 01:01:11 UTC) #1
felix8a
http://codereview.appspot.com/5492043/diff/1/src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java File src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java (right): http://codereview.appspot.com/5492043/diff/1/src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java#newcode227 src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java:227: new ExternalReference(absUri, baseAddress, relUri, this change allows absUri == ...
14 years, 10 months ago (2011-12-15 01:16:29 UTC) #2
Jasvir Nagra
http://codereview.appspot.com/5492043/diff/1/src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java File src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java (right): http://codereview.appspot.com/5492043/diff/1/src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java#newcode227 src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java:227: new ExternalReference(absUri, baseAddress, relUri, On 2011/12/15 01:16:29, felix8a wrote: ...
14 years, 10 months ago (2011-12-15 01:33:49 UTC) #3
felix8a
14 years, 10 months ago (2011-12-15 01:39:58 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b