Stopped symlink code creating extra dirs.

Stopped symlink code creating extra dirs.

Previously, trying to create a symlink of packages -> cache/package/lib
would create packages/lib. Now it will copy cache/package/lib to
packages doing the rename step at the same time.

R=tapted@chromium.org

Committed: https://github.com/tapted/bleeding_edge/commit/8a2311c

Committed: https://github.com/tapted/bleeding_edge/commit/a108354

[tapted, 2014-01-22 00:40:47]

lgtm with a nit

https://codereview.appspot.com/54920043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54920043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:332: if (from == null)
return log.error("Target of symlink doesn't exists");
nit: exists -> exist

Also it seems weird to return log.error. I'd probably go with

if (from == null) {
  log.error("Can't create symlink to target folder: $target");
  return null;
}

(unless you're following a Dart idiom)

[pajamallama, 2014-01-22 00:45:00]

Fixed weirdness.

https://codereview.appspot.com/54920043/diff/1/dart/sdk/lib/_internal/pub/lib...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54920043/diff/1/dart/sdk/lib/_internal/pub/lib...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:332: if (from == null)
return log.error("Target of symlink doesn't exists");
On 2014/01/22 00:40:48, tapted wrote:
> nit: exists -> exist
> 
> Also it seems weird to return log.error. I'd probably go with
> 
> if (from == null) {
>   log.error("Can't create symlink to target folder: $target");
>   return null;
> }
> 
> (unless you're following a Dart idiom)

Done.

[pajamallama, 2014-01-22 03:47:45]

Committed patchset #4 manually as r8a2311c (presubmit successful).

[tapted, 2014-01-22 03:59:45]

https://codereview.appspot.com/54920043/diff/60001/dart/sdk/lib/_internal/pub...
File dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart (right):

https://codereview.appspot.com/54920043/diff/60001/dart/sdk/lib/_internal/pub...
dart/sdk/lib/_internal/pub/lib/src/wrap/io_wrap.dart:288: <<<<<<< HEAD
Yeah, there's a presubmit in Chrome that can check for these on an upload. slgtm
once these are gone

[pajamallama, 2014-01-22 04:04:45]

Committed patchset #5 manually as ra108354 (presubmit successful).