code review 5489088: xgb: Modified SendEvent so now it accept Event type as ...

xgb: Modified SendEvent so now it accept Event type as argument

Fixes issue 7.

[ziutek, 2011-12-19 12:17:02]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/x-go-binding

[ziutek, 2011-12-19 13:52:15]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[nigeltao, 2011-12-19 23:55:13]

I've made a couple of comments, but...

I have a major xgb rewrite in the works. Amongst other things, it ought to make
fewer temporary []byte allocations. Can you hold off on this until v2 lands?

http://codereview.appspot.com/5489088/diff/4006/xgb/go_client.py
File xgb/go_client.py (right):

http://codereview.appspot.com/5489088/diff/4006/xgb/go_client.py#newcode312
xgb/go_client.py:312: if func_name == 'SendEvent':
The protocol itself calls this SendEvent, so I'd prefer to keep that name.
Instead, I'd rename what you currently call SendEvent to just Send.

http://codereview.appspot.com/5489088/diff/4006/xgb/xgb.go
File xgb/xgb.go (right):

http://codereview.appspot.com/5489088/diff/4006/xgb/xgb.go#newcode375
xgb/xgb.go:375: // If you need to send data put them only in one field and
This seems to be an unrelated change.

But also, all-zeroes can be valid client message data, but your design won't let
you send that.

[ziutek, 2011-12-20 10:52:27]

> I have a major xgb rewrite in the works. Amongst other things, it ought to
make
> fewer temporary []byte allocations. Can you hold off on this until v2 lands?

Ok. I also believe that this project should be completely rewritten (especially
for better error handling). I don't use xgb for serious stuff. I try write
simple WM in Go, mainly for fun: https://github.com/ziutek/mdtwm 

> http://codereview.appspot.com/5489088/diff/4006/xgb/go_client.py#newcode312
> xgb/go_client.py:312: if func_name == 'SendEvent':
> The protocol itself calls this SendEvent, so I'd prefer to keep that name.
> Instead, I'd rename what you currently call SendEvent to just Send.

OK.

> http://codereview.appspot.com/5489088/diff/4006/xgb/xgb.go#newcode375
> xgb/xgb.go:375: // If you need to send data put them only in one field and
> This seems to be an unrelated change.
> 
> But also, all-zeroes can be valid client message
> data, but your design won't let you send that.

If all DataX contains only zeros, the zeros from Data8 are copied.

Three was another bug in my putEvent, I fixed it to.

I'll send fixes, but I do not care to found it in official v1 repository.
Instead, I waiting for v2.

[ziutek, 2011-12-20 10:53:31]

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.