charm: must handle new revision schema

Revision handling was moved out of the metadata.yaml file.
The Go port most be updated to handle it.

This branch implements the new schema for charm revision handling
in an independent file, including backwards compatibility with
the previous schema, and also SetVersion methods that enable
bundling and expanding charms with custom revisions
(necessary for store).

https://code.launchpad.net/~niemeyer/juju/go-new-revisions/+merge/78728

(do not edit description out of merge proposal)

[niemeyer, 2011-12-19 10:51:48]

Please take a look.

[rog, 2011-12-19 12:36:16]

https://codereview.appspot.com/5489087/diff/1/all.bash
File all.bash (right):

https://codereview.appspot.com/5489087/diff/1/all.bash#newcode11
all.bash:11: dirs="schema environs environs/ec2 environs/jujutest charm"
should these changes be in this CL?

https://codereview.appspot.com/5489087/diff/1/charm/bundle.go
File charm/bundle.go (right):

https://codereview.appspot.com/5489087/diff/1/charm/bundle.go#newcode98
charm/bundle.go:98: // The Bundle type encapsulates access to data and
operations
move this type to the top of the file? (it's what this file is all about)

https://codereview.appspot.com/5489087/diff/1/charm/charm.go
File charm/charm.go (right):

https://codereview.appspot.com/5489087/diff/1/charm/charm.go#newcode9
charm/charm.go:9: SetRevision(revision int)
as discussed, i think SetRevision could be removed from this interface.

https://codereview.appspot.com/5489087/diff/1/environs/ec2/juju_test.go
File environs/ec2/juju_test.go (right):

https://codereview.appspot.com/5489087/diff/1/environs/ec2/juju_test.go#newco...
environs/ec2/juju_test.go:52: states := []ec2.InstanceState{
should this change be in this CL?

https://codereview.appspot.com/5489087/diff/1/environs/jujutest/Makefile
File environs/jujutest/Makefile (right):

https://codereview.appspot.com/5489087/diff/1/environs/jujutest/Makefile#newc...
environs/jujutest/Makefile:5: TARG=launchpad.net/juju/go/environs/jujutest
should this change be in this CL?

[niemeyer, 2011-12-19 12:52:43]

https://codereview.appspot.com/5489087/diff/1/all.bash
File all.bash (right):

https://codereview.appspot.com/5489087/diff/1/all.bash#newcode11
all.bash:11: dirs="schema environs environs/ec2 environs/jujutest charm"
> should these changes be in this CL?

I've made these changes trying to make tests for this branch pass. Not sure how
you've managed to get it to work before.

https://codereview.appspot.com/5489087/diff/1/charm/bundle.go
File charm/bundle.go (right):

https://codereview.appspot.com/5489087/diff/1/charm/bundle.go#newcode98
charm/bundle.go:98: // The Bundle type encapsulates access to data and
operations
> move this type to the top of the file? (it's what this file is all about)

Done.

https://codereview.appspot.com/5489087/diff/1/charm/charm.go
File charm/charm.go (right):

https://codereview.appspot.com/5489087/diff/1/charm/charm.go#newcode9
charm/charm.go:9: SetRevision(revision int)
> as discussed, i think SetRevision could be removed from this interface.

Done.

https://codereview.appspot.com/5489087/diff/1/environs/ec2/juju_test.go
File environs/ec2/juju_test.go (right):

https://codereview.appspot.com/5489087/diff/1/environs/ec2/juju_test.go#newco...
environs/ec2/juju_test.go:52: states := []ec2.InstanceState{
> should this change be in this CL?

No, it definitely shouldn't be here. It should have been submitted at the same
time that you changed ec2test, to prevent breaking our tip. Please watch out for
breaking tip, since it disrupts everything else.

Now that it's broken, though, I'm trying to get this branch in, and figured
those problems while working on the branch. Since they're trivial, it's fine to
get them in here.

https://codereview.appspot.com/5489087/diff/1/environs/jujutest/Makefile
File environs/jujutest/Makefile (right):

https://codereview.appspot.com/5489087/diff/1/environs/jujutest/Makefile#newc...
environs/jujutest/Makefile:5: TARG=launchpad.net/juju/go/environs/jujutest
> should this change be in this CL?

Ditto.

Please run tests before you commit, by the way. You'd have gotten the mistake
here.

[niemeyer, 2011-12-19 12:55:55]

Please take a look.

[rog, 2011-12-19 13:09:56]

LGTM

On 19 December 2011 12:55,  <n13m3y3r@gmail.com> wrote:
> Please take a look.
>
> https://codereview.appspot.com/5489087/

[niemeyer, 2011-12-19 13:15:25]

*** Submitted:

charm: must handle new revision schema

Revision handling was moved out of the metadata.yaml file.
The Go port most be updated to handle it.

This branch implements the new schema for charm revision handling
in an independent file, including backwards compatibility with
the previous schema, and also SetVersion methods that enable
bundling and expanding charms with custom revisions
(necessary for store).

R=rog
CC=
https://codereview.appspot.com/5489087