code review 54890043: runtime: fix test on windows

runtime: fix test on windows
The test prints an excessive \n when /dev/null is not present.

[dvyukov, 2014-01-21 06:39:22]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[bradfitz, 2014-01-21 06:40:36]

LGTM but fix change description typo
 On Jan 20, 2014 10:39 PM, <dvyukov@google.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://dvyukov%40google.com@code.google.com/p/go/
>
>
> Description:
> runtime: fix test on windows
> The test prints an excessive \n is /dev/null is not present.
>
> Please review this at https://codereview.appspot.com/54890043/
>
> Affected files (+1, -1 lines):
>   M src/pkg/runtime/proc_test.go
>
>
> Index: src/pkg/runtime/proc_test.go
> ===================================================================
> --- a/src/pkg/runtime/proc_test.go
> +++ b/src/pkg/runtime/proc_test.go
> @@ -268,7 +268,7 @@
>         if os.IsNotExist(err) {
>                 // This test tests what it is intended to test only if
> writes are fast.
>                 // If there is no /dev/null, we just don't execute the
> test.
> -               fmt.Println("OK\n")
> +               fmt.Println("OK")
>                 return
>         }
>         if err != nil {
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[dave_cheney.net, 2014-01-21 06:41:29]

On 2014/01/21 06:39:22, dvyukov wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://dvyukov%2540google.com%40code.google.com/p/go/

LGTM, please fix the title, s/is/when is/g

[dave_cheney.net, 2014-01-21 06:42:04]

On 2014/01/21 06:41:29, dfc wrote:
> On 2014/01/21 06:39:22, dvyukov wrote:
> > Hello mailto:golang-codereviews@googlegroups.com,
> > 
> > I'd like you to review this change to
> > https://dvyukov%252540google.com%2540code.google.com/p/go/
> 
> LGTM, please fix the title, s/is/when is/g

Sorry, that was not at all clear,

The test prints an excessive \n when /dev/null is not present.

[dvyukov, 2014-01-21 06:43:56]

On 2014/01/21 06:42:04, dfc wrote:
> On 2014/01/21 06:41:29, dfc wrote:
> > On 2014/01/21 06:39:22, dvyukov wrote:
> > > Hello mailto:golang-codereviews@googlegroups.com,
> > > 
> > > I'd like you to review this change to
> > > https://dvyukov%25252540google.com%252540code.google.com/p/go/
> > 
> > LGTM, please fix the title, s/is/when is/g
> 
> Sorry, that was not at all clear,
> 
> The test prints an excessive \n when /dev/null is not present.

done

[dvyukov, 2014-01-21 06:44:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=5cfa2c933b76 ***

runtime: fix test on windows
The test prints an excessive \n when /dev/null is not present.

R=golang-codereviews, bradfitz, dave
CC=golang-codereviews
https://codereview.appspot.com/54890043