Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(986)

Issue 5487080: Separate ports from core.gyp

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by caryclark1
Modified:
12 years, 4 months ago
Reviewers:
epoger, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Create ports.gyp so that future additional includes for ports does not pollute core.gyp.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -44 lines) Patch
M gyp/FileReaderApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/core.gyp View 5 chunks +0 lines, -44 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/iOSSampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A gyp/ports.gyp View 1 chunk +106 lines, -0 lines 0 comments Download
M gyp/tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tools.gyp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3
caryclark1
12 years, 4 months ago (2011-12-14 16:28:19 UTC) #1
reed1
lgtm, tho elliot should take a peek
12 years, 4 months ago (2011-12-14 16:57:53 UTC) #2
epoger
12 years, 4 months ago (2011-12-14 17:09:55 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b