Issue 54870043: Don't bootstrap for non-executable tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 54870043: Don't bootstrap for non-executable tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by bcsaller

Modified:
10 years, 3 months ago

Reviewers:
Marco Ceppi, mp+202400

Visibility:
Public.

Description

Don't bootstrap for non-executable tests This makes an effort to skip tests that can't exec. It does change the policy that tests that expect to execute must be executable, but we don't know the interpreter w/o that anyway. This also moves the find_test tests from being all mocks to using real code which is a win IMO. https://code.launchpad.net/~bcsaller/charm-tools/test-minimal-working-set/+merge/202400 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Don't bootstrap for non-executable tests #

Patch Set 3 : Don't bootstrap for non-executable tests #

Patch Set 4 : Don't bootstrap for non-executable tests #

Patch Set 5 : Don't bootstrap for non-executable tests #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -46 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmtools/test.py	View	4 chunks	+24 lines, -20 lines	0 comments	Download
M	tests/test_juju_test.py	View	3 chunks	+32 lines, -26 lines	0 comments	Download
A	tests_functional/charms/test/tests/00_setup	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests_functional/charms/test/tests/helper.bash	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Marco Ceppi

On 2014/01/21 06:08:01, bcsaller wrote: > Please take a look. LGTM +1

10 years, 3 months ago (2014-01-21 15:33:48 UTC) #2

bcsaller

10 years, 3 months ago (2014-01-21 16:38:12 UTC) #3

*** Submitted:

Don't bootstrap for non-executable tests

This makes an effort to skip tests that can't exec. It does
change the policy that tests that expect to execute must 
be executable, but we don't know the interpreter w/o that
anyway.

This also moves the find_test tests from being all mocks
to using real code which is a win IMO.

R=Marco Ceppi
CC=
https://codereview.appspot.com/54870043

Expand All Messages | Collapse All Messages