Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(210)

Issue 5486057: preload guest frame (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by felix8a
Modified:
14 years, 10 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Right now, caja.js does load taming frame when taming frame ready load guest frame when guest frame ready run gadget This is unnecessarily serial. Since we always need at least one guest frame, we can start loading one before the taming frame is ready. This change wraps guest frame creation in a frameMaker object that can preload a frame and supply it to a later call to frameMaker.make().

Patch Set 1 #

Patch Set 2 : preload guest frame #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -12 lines) Patch
M src/com/google/caja/plugin/caja.js View 1 3 chunks +54 lines, -8 lines 0 comments Download
M src/com/google/caja/plugin/es53-frame-group.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/ses-frame-group.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
felix8a
14 years, 10 months ago (2011-12-13 23:05:00 UTC) #1
metaweta
lgtm
14 years, 10 months ago (2011-12-13 23:28:09 UTC) #2
felix8a
14 years, 10 months ago (2011-12-13 23:58:39 UTC) #3
@r4681
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b