Issue 5486053: unglobalize plugin_dispatch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5486053: unglobalize plugin_dispatch (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by felix8a

Modified:
14 years, 10 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

currently, plugin_dispatchEvent___ and plugin_dispatchHandler___ are added to the global namespace. this change moves those functions to the ___ object.

Patch Set 1 #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -28 lines)			Patch
M	build.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/com/google/caja/demos/playground/es53.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/caja/plugin/domado.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/es53-frame-group.js	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	src/com/google/caja/plugin/ses-frame-group.js	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	src/com/google/caja/plugin/templates/HtmlAttributeRewriter.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/com/google/caja/plugin/PipelineCacheTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/domita_test_untrusted.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/es53-test-domado-forms-guest.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/templates/TemplateCompilerTest.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/template-compiler-golden1-dynamic.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/template-compiler-golden1-nulluripol.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/template-compiler-golden1-static.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

metaweta

lgtm. I'd been trying to stick plugin_dispatch* on the caja object, but ___ is a ...

14 years, 10 months ago (2011-12-13 21:32:07 UTC) #2

@r4680

Expand All Messages | Collapse All Messages